refactor: prb feedback #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
requested changes
Feb 4, 2025
|
Thank you @smol-ninja, will wait for @razgraf to confirm if any feedback/concerns/queries |
razgraf
approved these changes
Feb 4, 2025
|
Looks good to me! The airdrops dashboard itself suffered some changes as well so if you want to
it would be a good addition. It's not urgent through, we can always update later if you want to get this moving, will leave it up to you. Thanks for updating the other screenshots and sections! |
refactor: dedup and simplify release history refactor: delete promo video section refactor: delete superfluous sections in CSV guide refactor: get rid of "group" terminology refactor: rename images refactor: improve CSV guide refactor: improve wording and order alphabetically refactor: update batch creation limits refactor: update Airdrops app guide
PaulRBerg
force-pushed
the
refactor/prb-feedback
branch
from
4484cd5 to
38a0a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My feedback on #238, and then some.
cc @smol-ninja @razgraf not sure if you wanna review this or we can just merge directly
Closes #252 and #251