Skip to content

fix(web): nft image overlap on text in tx flow #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(web): nft image overlap on text in tx flow #5684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/tx-flow/flows/NftTransfer/SendNftBatch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type SendNftBatchProps = {
}

const NftItem = ({ image, name, description }: { image: string; name: string; description?: string }) => (
<Stack direction="row" spacing={1} flexWrap="nowrap" alignItems="flex-start">
<Stack direction="row" spacing={2} flexWrap="nowrap" alignItems="flex-start">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about a bigger spacing. 1 is OK too. It's about rectangular (non-square) images overflowing out of their container and overlapping with the text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, got it. That is why the changes are more complex than I expected. Would like to get the NFT from @liliya-soroka to make the correct changes. Thanks.

<Box flex={0}>
<ImageFallback
src={image}
Expand Down
Loading