Skip to content

Fix 65514 #68020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Fix 65514 #68020

merged 3 commits into from
May 15, 2025

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented May 13, 2025

What does this PR do?

Adds content to the comment field when test=True for all state functions in the reg state module.

What issues does this PR fix or reference?

Fixes #65514

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Nimrod Abing and others added 3 commits May 13, 2025 14:48
When running with `test=True` the `reg.present`, `reg.absent`, and
`reg.key_absent` states do not return a comment field. The missing
`comment` field causes RaaS to show a empty error column when running
assessment for Windows checks that make use of the `reg` states.
@twangboy twangboy requested a review from a team as a code owner May 13, 2025 21:53
@twangboy twangboy self-assigned this May 13, 2025
@twangboy twangboy added this to the Sulfur v3006.11 milestone May 13, 2025
@twangboy twangboy added the test:full Run the full test suite label May 14, 2025
@twangboy twangboy requested a review from dwoz May 14, 2025 15:03
@dwoz dwoz merged commit 4a24de9 into saltstack:3006.x May 15, 2025
1448 of 1450 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants