Skip to content

feat: editor context menu stub #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

johnnyschneider
Copy link

@johnnyschneider johnnyschneider commented Aug 1, 2025

Screenshot 2025-08-01 at 11 58 06 AM

Self explanatory, I'd hope. PR also includes some routine package version bumps including a bump to a vulnerability in esbuild. Validated build and install success of new bumps in local.

@sapegin sapegin requested a review from Copilot August 2, 2025 09:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a context menu integration for the justBlame extension that appears in the editor's right-click menu, along with routine package version updates including a security fix for esbuild.

  • Adds editor context menu support with "Toggle Blame" command
  • Updates VS Code engine requirement and activation event
  • Bumps various package versions including security fix for esbuild
Comments suppressed due to low confidence (2)

package.json:151

  • TypeScript 5.9.2 does not exist. The latest TypeScript 5.x version as of my knowledge cutoff is 5.7.2. Consider using a valid TypeScript version.
    "typescript": "^5.9.2"

package.json:150

  • Prettier 3.6.2 does not exist. The latest Prettier 3.x version as of my knowledge cutoff is 3.4.2. Consider using a valid Prettier version.
    "prettier": "^3.6.2",

Copy link
Owner

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a pull request!

Comment on lines +46 to +48
"activationEvents": [
"onStartupFinished"
],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work without this, like it does now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran VSCE without it, it would yell at me. I didn't actually try it, I just got an angry message. I can try it.

Copy link
Author

@johnnyschneider johnnyschneider Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapegin

image

When I run vsce package in that repo without the code highlighted, this^ is what I get. It outright refuses to build. If vsce package is not a part of your publication process, then perhaps it will run...

I chose the "startup event" that made the most sense to me. Take a walkthrough here, perhaps one makes more sense to you?

In hindsight, something like workspaceContains might make more sense.

"activationEvents": [
    "workspaceContains:**/.git"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants