-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: editor context menu stub #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a context menu integration for the justBlame extension that appears in the editor's right-click menu, along with routine package version updates including a security fix for esbuild.
- Adds editor context menu support with "Toggle Blame" command
- Updates VS Code engine requirement and activation event
- Bumps various package versions including security fix for esbuild
Comments suppressed due to low confidence (2)
package.json:151
- TypeScript 5.9.2 does not exist. The latest TypeScript 5.x version as of my knowledge cutoff is 5.7.2. Consider using a valid TypeScript version.
"typescript": "^5.9.2"
package.json:150
- Prettier 3.6.2 does not exist. The latest Prettier 3.x version as of my knowledge cutoff is 3.4.2. Consider using a valid Prettier version.
"prettier": "^3.6.2",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for a pull request!
"activationEvents": [ | ||
"onStartupFinished" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work without this, like it does now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran VSCE without it, it would yell at me. I didn't actually try it, I just got an angry message. I can try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

When I run vsce package
in that repo without the code highlighted, this^ is what I get. It outright refuses to build. If vsce package
is not a part of your publication process, then perhaps it will run...
I chose the "startup event" that made the most sense to me. Take a walkthrough here, perhaps one makes more sense to you?
In hindsight, something like workspaceContains might make more sense.
"activationEvents": [
"workspaceContains:**/.git"
]
Self explanatory, I'd hope. PR also includes some routine package version bumps including a bump to a vulnerability in
esbuild
. Validated build and install success of new bumps in local.