Skip to content

Remove or fix persistent mesh import of "ordinary" STL files #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
philippotto opened this issue Jul 23, 2021 · 2 comments · May be fixed by #8554
Open
1 of 2 tasks

Remove or fix persistent mesh import of "ordinary" STL files #5633

philippotto opened this issue Jul 23, 2021 · 2 comments · May be fixed by #8554

Comments

@philippotto
Copy link
Member

philippotto commented Jul 23, 2021

In addition to computing meshes ad-hoc and loading meshes from precomputed files, we also have the support to import STL files into a tracing view. The import handles two cases:

(1) Import an STL which was previously downloaded via webKnossos (that file encodes the segment id in the header and can be restored as if the mesh was just recomputed).
(2) Import an STL which was created by another program. For such an STL we have very little information (i.e., don't know which segment is represented).

For (2) we once built the feature to store the mesh on the back-end. Also, properties, such as the position and scale, of the mesh could be edited in the UI. This feature has always been kind of obscure and probably wasn't used much for that reason.

I noticed that the support for ordinary STL files is broken currently. Importing such an STL adds the mesh to the scene, but it's not listed in the sidebar. I couldn't find my dummy files in the scene, so I'm not even sure, there are rendered properly.

We should discuss whether the support for persisted and "ordinary" STL should be repaired or simply removed. I'd vote for the latter.

Remove in:

  • frontend
  • backend
@philippotto
Copy link
Member Author

For the record: We decided to remove the "ordinary" STL support.

@philippotto
Copy link
Member Author

Some users reported that they used the STL feature to add some shapes, such as planes:

image

We might want to reconsider the support for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants