Remove stored meshes feature from backend and postgres #8554
Conversation
📝 WalkthroughWalkthroughThis change set removes all backend support for persisted mesh storage and management. It deletes the mesh-related controller, data model, service, and DAO, as well as all corresponding HTTP routes. The database schema is updated to drop the Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
conf/evolutions/131-remove-stored-meshes.sql (2)
1-1: Enforce pre-migration schema version
The DO block correctly asserts that the current schema version is 130 before applying this evolution, preventing out-of-order or duplicate migrations.
3-4: Use IF EXISTS for idempotence
Dropping the view and table withoutIF EXISTSmay cause failures if they’ve already been removed. Consider:-DROP VIEW webknossos.meshes_; -DROP TABLE webknossos.meshes; +DROP VIEW IF EXISTS webknossos.meshes_; +DROP TABLE IF EXISTS webknossos.meshes;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
MIGRATIONS.unreleased.md(1 hunks)app/controllers/MeshController.scala(0 hunks)app/models/mesh/Mesh.scala(0 hunks)conf/evolutions/131-remove-stored-meshes.sql(1 hunks)conf/evolutions/reversions/131-remove-stored-meshes.sql(1 hunks)conf/webknossos.latest.routes(0 hunks)tools/postgres/schema.sql(1 hunks)
💤 Files with no reviewable changes (3)
- conf/webknossos.latest.routes
- app/controllers/MeshController.scala
- app/models/mesh/Mesh.scala
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: backend-tests
- GitHub Check: build-smoketest-push
- GitHub Check: frontend-tests
🔇 Additional comments (7)
conf/evolutions/131-remove-stored-meshes.sql (1)
6-6: Bump schema version forward
UpdatingreleaseInformationto 131 aligns the database state with this new evolution.MIGRATIONS.unreleased.md (1)
13-13: Document new Postgres evolution
Including131-remove-stored-meshes.sqlunder “Postgres Evolutions” ensures it’s applied for fresh deployments.tools/postgres/schema.sql (1)
24-24: Initialize to new baseline version
Adjusting the insertedschemaVersionto 131 makes sure clean installs start at the correct migration level.conf/evolutions/reversions/131-remove-stored-meshes.sql (4)
1-1: Verify pre-reversion schema version
The assertion ensures the schema is at 131 before running the rollback, preventing misaligned downgrades.
4-12: Recreatemeshestable schema
The table definition, including its columns, defaults, and checks, matches the original schema prior to removal.
14-18: Re-establish view and foreign key
Recreatingwebknossos.meshes_and re-adding the FK constraint restores the data model for stored meshes.
19-19: Revert schema version back
DowngradingreleaseInformationto 130 correctly resets the migration state after undoing the table removal.
User-supplied meshes stored in postgres were already inaccessible since #6960 removed the frontend code two years ago.
This PR removes the relevant code as well and drops the mesh data from postgres.
This does not change how meshfiles or ad-hoc meshing is handled.
Steps to test:
Issues: