Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace docker compose script in yarn #8541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace docker compose script in yarn #8541
Changes from all commits
024e8f5
d377570
9f8c3d7
4cd010d
2ca953d
5dd8e54
594ca94
5a640cb
43530a8
4535599
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Enhance shell strictness for safer execution
Currently the script uses
set -xe
, but adding stricter options can catch more classes of failures and undefined variables:-u
: error on unset variables-o pipefail
: propagate failures in pipelines-x
(trace) and-e
(exit on error)This hardens the script and surfaces issues early.
🏁 Script executed:
Length of output: 398
Enhance shell strictness for safer execution in tools/refresh-screenshots.sh
In the shebang section, replace:
-u
: error on unset variables (e.g.$URL
,$WK_AUTH_TOKEN
)-o pipefail
: catch failures in any pipeline-x
(command tracing) and-e
(exit on error)This hardens the script and surfaces issues early.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix globbing to reliably clear screenshots
The pattern
**
requiresshopt -s globstar
(not enabled by default), so it may not remove nested files. A simpler, reliable approach is:Or explicitly enable recursive globbing at the top:
shopt -s globstar
Either ensures the directory is properly emptied.