Skip to content

[6.15] Switch ALL Novatek nt36672a based panels to common driver #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: qcom-sdm660-6.15.y
Choose a base branch
from
Open

[6.15] Switch ALL Novatek nt36672a based panels to common driver #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
37801a9
drm/panel: nt36672a: Switch to modern refcounted allocation API
minlexx Jun 20, 2025
3c4f207
drm/panel: nt36672a: Switch from 2-byte arrays to init functions
minlexx May 13, 2025
9d1dbc1
drm/panel: nt36672a: Change driver name to novatek for consistency
minlexx Jun 20, 2025
0a7ed1a
drm/panel: nt36672a: Add Tianma panel used in Xiaomi Redmi Note 7
minlexx May 13, 2025
bfcb07f
drm/panel: nt36672a: Add Tianma panel used in Xiaomi Mi A2
minlexx May 29, 2025
acee180
drm/panel: nt36672a: Add Tianma panel used in Xiaomi Redmi Note 6 Pro
minlexx May 30, 2025
929b896
drm/panel: nt36672a: Add TXD panel used in Asus Zenfone Max Pro M1
iAboothahir Jun 15, 2025
339f2e7
fixup! arm64: dts: qcom: sdm660-xiaomi-lavender: Split by display
minlexx May 29, 2025
38e5231
fixup! arm64: dts: qcom: sdm660: Add device tree for Xiaomi Mi A2 (ja…
minlexx May 31, 2025
99375d3
fixup! arm64: dts: qcom: add device-tree for Redmi Note 6 Pro (tulip)
minlexx May 31, 2025
4308f89
fixup! arm64: dts: qcom: Add initial support for asus-x00td
iAboothahir Jun 15, 2025
c1fbf6f
Input: novatek-nvt-ts - support being panel follower
minlexx Jun 5, 2025
90e8467
drm/panel: nt36672a: Add Shenchao panel used in Xiaomi Redmi Note 7
flamingradian Aug 7, 2025
dfd0774
dt-bindings: arm: qcom: Add xiaomi-lavender with shenchao panel
flamingradian Aug 7, 2025
dfda14f
arm64: dts: qcom: add Xiaomi Redmi Note 7 with Shenchao panel
flamingradian Aug 7, 2025
9fb9de9
HACK drm/panel: move some dsi commands from unprepare to disable
minlexx Aug 12, 2025
e383456
dt-bindings: display: novatek,nt36672a: Add 5 new panels
minlexx Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/devicetree/bindings/arm/qcom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,7 @@ properties:
- xiaomi,jasmine
- xiaomi,lavender
- xiaomi,lavender-boe
- xiaomi,lavender-shenchao
- xiaomi,lavender-tianma
- xiaomi,platina
- const: qcom,sdm660
Expand Down
6 changes: 6 additions & 0 deletions Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ properties:
items:
- enum:
- tianma,fhd-video
- novatek,nt36672a-shenchao-lavender
- novatek,nt36672a-tianma-beryllium
- novatek,nt36672a-tianma-lavender
- novatek,nt36672a-tianma-jasmine
- novatek,nt36672a-tianma-tulip
- novatek,nt36672-txd-x00td
- const: novatek,nt36672a
description: This indicates the panel manufacturer of the panel that is
in turn using the NT36672A panel driver. This compatible string
Expand Down
1 change: 1 addition & 0 deletions arch/arm64/boot/dts/qcom/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm636-xiaomi-tulip.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm636-xiaomi-whyred.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-clover-plus.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-jasmine.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-lavender-shenchao.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-lavender-tianma.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-lavender-boe.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm660-xiaomi-platina.dtb
Expand Down
16 changes: 8 additions & 8 deletions arch/arm64/boot/dts/qcom/sdm636-asus-x00td.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,15 @@

status = "okay";

touchscreen@62 {
compatible = "novatek,nt36525";
reg = <0x62>;
vdd-supply = <&vreg_l11a_1p8>;
interrupt-parent = <&tlmm>;
interrupts = <67 IRQ_TYPE_EDGE_RISING>;
touchscreen@1 {
compatible = "novatek,nt36672a-ts";
reg = <0x1>;
iovcc-supply = <&vreg_l11a_1p8>;
interrupts-extended = <&tlmm 67 IRQ_TYPE_EDGE_RISING>;
pinctrl-names = "default", "sleep";
pinctrl-0 = <&ts_pins_active>;
pinctrl-1 = <&ts_int_sleep &ts_rst_sleep>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_HIGH>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;
touchscreen-size-x = <1080>;
touchscreen-size-y = <2160>;
};
Expand Down Expand Up @@ -251,8 +250,9 @@

panel: panel@0 {
reg = <0>;
compatible = "mdss,novatek-nt36672-txd";
compatible = "novatek,nt36672-txd-x00td", "novatek,nt36672a";

vddio-supply = <&vreg_l11a_1p8>;
backlight = <&pm660l_wled>;

reset-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
Expand Down
19 changes: 8 additions & 11 deletions arch/arm64/boot/dts/qcom/sdm636-xiaomi-tulip.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,15 @@
&blsp_i2c1 {
status = "okay";

/* Novatek NT36672A touchscreen */
touchscreen@62 {
compatible = "novatek,nt36525";
reg = <0x62>;
interrupt-parent = <&tlmm>;
vdd-supply = <&vreg_l11a_1p8>;
vio-supply = <&vreg_l11a_1p8>;
interrupts = <67 IRQ_TYPE_EDGE_RISING>;
touchscreen@1 {
compatible = "novatek,nt36672a-ts";
reg = <0x1>;
iovcc-supply = <&vreg_l11a_1p8>;
interrupts-extended = <&tlmm 67 IRQ_TYPE_EDGE_RISING>;
pinctrl-names = "default", "sleep";
pinctrl-0 = <&ts_pins_active>;
pinctrl-1 = <&ts_int_sleep &ts_rst_sleep>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_HIGH>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;
touchscreen-size-x = <1080>;
touchscreen-size-y = <2280>;
};
Expand Down Expand Up @@ -179,11 +176,11 @@
vdda-supply = <&vreg_l1a_1p225>;

panel: panel@0 {
compatible = "tianma,nt36672a-xiaomi-tulip-simple";
compatible = "novatek,nt36672a-tianma-tulip", "novatek,nt36672a";
reg = <0>;

reset-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;

vddio-supply = <&vreg_l11a_1p8>;
backlight = <&pm660l_wled>;

pinctrl-names = "default";
Expand Down
22 changes: 10 additions & 12 deletions arch/arm64/boot/dts/qcom/sdm660-xiaomi-jasmine.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,17 +148,16 @@
&blsp_i2c1 {
status = "okay";

/* Novatek NT36672A touchscreen */
touchscreen@62 {
compatible = "novatek,nt36525";
reg = <0x62>;
vdd-supply = <&vreg_l11a_1p8>;
interrupt-parent = <&tlmm>;
interrupts = <67 IRQ_TYPE_EDGE_RISING>;
touchscreen@1 {
compatible = "novatek,nt36672a-ts";
reg = <0x1>;
iovcc-supply = <&vreg_l11a_1p8>;
interrupts-extended = <&tlmm 67 IRQ_TYPE_EDGE_RISING>;
panel = <&panel>;
pinctrl-names = "default", "sleep";
pinctrl-0 = <&ts_pins_active>;
pinctrl-1 = <&ts_int_sleep &ts_rst_sleep>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_HIGH>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;
touchscreen-size-x = <1080>;
touchscreen-size-y = <2160>;
};
Expand All @@ -177,13 +176,12 @@
vdd-supply = <&vreg_l1b_0p925>;
vdda-supply = <&vreg_l1a_1p225>;

panel@0 {
compatible = "mdss,nt36672-tianma";
panel: panel@0 {
compatible = "novatek,nt36672a-tianma-jasmine", "novatek,nt36672a";
reg = <0>;

reset-gpios = <&tlmm 53 GPIO_ACTIVE_LOW>;
disp-te-gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>;

vddio-supply = <&vreg_l11a_1p8>;
backlight = <&pm660l_wled>;

pinctrl-names = "default";
Expand Down
64 changes: 64 additions & 0 deletions arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender-shenchao.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Copyright (c) 2024, Barnabas Czeman <[email protected]>
*/

/dts-v1/;

#include "sdm660-xiaomi-lavender-common.dtsi"

/ {
model = "Xiaomi Redmi Note 7 (Shenchao)";
compatible = "xiaomi,lavender-shenchao", "qcom,sdm660";
};

&blsp_i2c1 {
status = "okay";

touchscreen@1 {
compatible = "novatek,nt36672a-ts";
reg = <0x1>;

iovcc-supply = <&vreg_l11a_1p8>;
interrupts-extended = <&tlmm 67 IRQ_TYPE_EDGE_RISING>;

panel = <&panel>;

pinctrl-names = "default", "sleep";
pinctrl-0 = <&ts_pins_active>;
pinctrl-1 = <&ts_int_sleep &ts_rst_sleep>;

reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;

touchscreen-size-x = <1080>;
touchscreen-size-y = <2340>;
};
};

&panel {
compatible = "novatek,nt36672a-shenchao-lavender", "novatek,nt36672a";
vddio-supply = <&vreg_l11a_1p8>;
};

&tlmm {
ts_pins_active: ts-pins-active-state {
pins = "gpio66", "gpio67";
function = "gpio";
drive-strength = <16>;
bias-pull-up;
};

ts_rst_sleep: ts-rst-sleep-state {
pins = "gpio66";
function = "gpio";
drive-strength = <2>;
bias-pull-down;
};

ts_int_sleep: ts-int-sleep-state {
pins = "gpio67";
function = "gpio";
drive-strength = <2>;
bias-disable;
};
};
23 changes: 14 additions & 9 deletions arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender-tianma.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,29 @@
&blsp_i2c1 {
status = "okay";

/* Novatek NT36672A touchscreen */
touchscreen@62 {
compatible = "novatek,nt36525";
reg = <0x62>;
vdd-supply = <&vreg_l11a_1p8>;
interrupt-parent = <&tlmm>;
interrupts = <67 IRQ_TYPE_EDGE_RISING>;
touchscreen@1 {
compatible = "novatek,nt36672a-ts";
reg = <0x1>;

iovcc-supply = <&vreg_l11a_1p8>;
interrupts-extended = <&tlmm 67 IRQ_TYPE_EDGE_RISING>;

panel = <&panel>;

pinctrl-names = "default", "sleep";
pinctrl-0 = <&ts_pins_active>;
pinctrl-1 = <&ts_int_sleep &ts_rst_sleep>;
reset-gpios = <&tlmm 66 GPIO_ACTIVE_HIGH>;

reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;

touchscreen-size-x = <1080>;
touchscreen-size-y = <2340>;
};
};

&panel {
compatible = "tianma,nt36672a-xiaomi-lavender-simple";
compatible = "novatek,nt36672a-tianma-lavender", "novatek,nt36672a";
vddio-supply = <&vreg_l11a_1p8>;
};

&tlmm {
Expand Down
Loading
Loading