New devices: Blackberry KEY2 (athena) and KEY2 LE (luna) #97
Conversation
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
bcafa30 to
7684de3
Compare
|
Please open CI (actions) checks named "Device tree validation", expand the "Analyze results" section and fix all the dt-schema validation errors that are fixable within your |
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
3d71d3e to
3b77ce1
Compare
|
All commits that are intended to go upstream should have proper descriptions in commit messages. (Commit modifying sdm660_defconfig, which is not upstream, does not qualify here). I not fully understand, you have have changed ~1300 lines in this PR, but can't type few words to describe your changes?.. For inspiration l'd suggest to look for similar commits around neighbouring files histories, or ask more questions |
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
2 times, most recently
from
6b55943 to
d8f38b5
Compare
|
Can you attach dmesg of booting to OP post? |
added. |
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
d8f38b5 to
97b4208
Compare
There was a problem hiding this comment.
Alright, I have not checked very thoroughly dts compliance with dts-coding-style - things like order of nodes, order of properties, but I hope at least most style issues are now fixed. Surely kernel maintainers can find more issues, but I don't want to spend more time on this :)
I'll not review keypad patch or panel driver too much - outsdide of my knowledge.
But for panel driver though I think compatible string may be a problem, it should include panel vendor name (wtf is luna vendor in luna,livata? Is it in vendor-prefixes.yaml? no) and perhaps controller name. Is it possible to get information on what panel is actually used there, from some schematics/repair manuals, or by disassembling and looking for part labels?
I'd suggest to send stmpe pad fixes upstream, and perhaps panel driver too, to get some feedback on those.
For panel name I suppose I had a misunderstanding. I thought tianma in tianma,td4310 referred to xiaomi-beryllium-tianma, but it turns out tianma is a company name. I was thinking maybe for an unknown panel it was ok to use the name of the device and the name of the panel. I'll try to see if I can find more info and if not maybe change it to bbry,livata. |
all I know about it is this dtsi from downstream https://github.com/tim-ecoder/blackberry-android-linux-kernel/blob/sdm660-sdm636/ACW142/krab-luna-droidian/arch/arm64/boot/dts/qcom/dsi-panel-livata-video.dtsi |
I think it's boe. https://www.alibaba.com/product-detail/BOE-BV045FHM-L00-1S00-4-5_1600095821720.html |
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
2 times, most recently
from
c025878 to
e6c3317
Compare
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
3 times, most recently
from
e822dce to
25f3c94
Compare
sajattack
changed the title
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
4 times, most recently
from
4e7502b to
26bf591
Compare
|
pushing some changes for panels I haven't tested yet, converting to draft. |
This chip variant differs from others - it has different register map and swapped rows/columns. Signed-off-by: Sergey Larin <[email protected]>
for display and touch controllers. Implement a simple device driver for such panels, along with its built-in LED backlight controller, and add support for TD4101 and TD4300 panels in the driver. Signed-off-by: Kaustabh Chakraborty <[email protected]>
The mfd is already supported upstream, but not in the dt-bindings. Signed-off-by: Paul Sajna <[email protected]>
Signed-off-by: Paul Sajna <[email protected]>
Used by some BlackBerry phones including KEY2 LE (luna) https://www.panelook.com/BV045FHM-L00-1S00_BOE_4.5_LCM_overview_36174.html Generated by mdss-panel-generator Signed-off-by: Paul Sajna <[email protected]>
That's what they referred to themselves as in downstream kernels (at least TCL ones) Signed-off-by: Paul Sajna <[email protected]>
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
26bf591 to
aa36c59
Compare
Add bbry,luna-boe, bbry,luna-syna under supported sdm636 devices Add bbry,athena-boe, bbry-athena-syna under supported sdm660 devices Signed-off-by: Paul Sajna <[email protected]>
… sdm636-bbry-luna-common, sdm660-bbry-athena-boe, sdm660-bbry-athena-syna, sdm636-bbry-luna-syna, and sdm636-bbry-luna-boe for BlackBerry KEY2 and KEY2 LE working features: - Internal MMC - External SDcard - Wi-Fi - Bluetooth - Keypad - Panel - GPU (bit crashy) - fuel gauge - volume buttons - usb TODO: - keypad backlight - modem - audio - 3-button row - gps - fm radio - camera
Signed-off-by: Paul Sajna <[email protected]>
sajattack
force-pushed
the
saj/bbry-luna-for-upstream
branch
from
aa36c59 to
59c7fb4
Compare
Adds:
Updates:
dmesg.txt
unmerged 3rdparty patches