-
Notifications
You must be signed in to change notification settings - Fork 0
[ENHANCEMENT-37] #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shashanksingh
wants to merge
50
commits into
master
Choose a base branch
from
ENHANCEMENT-37
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENHANCEMENT-37] #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
shashanksingh
commented
Aug 16, 2020
•
edited
Loading
edited
- Closes GRPC Client for a full-fledged problem statement like find cheapest transaction with forex #37
- Closes Make example Client work #40
- closes [Spike] Find One Demo / example form real life #27
python -m clients.examples.create_grid message: "ALl hail GRPC" success_message { message: "yay" }l
* lets add grpc web proxy * everyone gets their docker file * fixed envoy file name * proto * better graph db primites * trying to make a wokring call * fixes #26 * used black * clients needs fix too * foxed make file § * better to run it as module * emoji support * emoji are welcomed * get emojis * small black fix * fixed stub * still trying to call server , but it gets called * fixed enum * fixed enu name * more query service * service is being called * ping ping works * struggling with status * finally some form communicationis happening on client and server python -m clients.examples.create_grid message: "ALl hail GRPC" success_message { message: "yay" }l * fixes * atleast some stuff is being called * fixing proto based on https://www.freecodecamp.org/news/googles-protocol-buffers-in-python/ * create grid needs fix * almost there § * fixng * added invlaid to enum * almost there, cleaning up code * added abstractclass method * no objects of abstract class * fixes #39 thanks to commit before this one fixes #5 thanks to this commit * undircted also gets it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.