Skip to content

feat: relaxing aws provider version constraint for eks-addons #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukeskywlkr
Copy link

Summary 💡

This PR relaxes the aws eks addons module provider version constraint. This is necessary in case some terraform project use a newer version of the aws provider.

Closes:

Relates:

Description 📝

Changed version constraint in eks_module from ~> 4.67 to >= 4.67.

Breaking Changes 💔

None

Tests performed 🧪

Performed a terraform init and terraform plan with aws provider v5.81

Future work 🔧

None

Copy link
Member

@stefanoghinelli stefanoghinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new constraint is quite permissive considering that the provider is at version 6.3.0, a terraform init could download the latest with possible untested breaking changes. Please:

  • Test at least v6.0.0 and v6.3.0 (not just v5.81)
  • Evaluate if needed a more safe constraint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants