first pass at implementing a zap log handler for slog

[EasterTheBunny]

Requires

Supports

[jmank88]

Suggested change

	package v2
	package logger

[jmank88]

I think we should target a zapcore.Core, no?

[EasterTheBunny]

The only reason I used this was to allow users to drop in an existing logger. I thought it might make the conversion easier.

[jmank88]

Which users though? I think we want to hide these details as much as possible from typical logging users. The more interesting "user" is the core logger package, which needs to use this internally to stay aligned.

[EasterTheBunny]

I played around with using a zapcore.Core instead, but I needed to work around errors. If we use zap.Logger, we can directly pass the logger from v1 over to v2 and if it's nil we can grab a global logger with zap.L(). This allows us to return a slog.Logger without an error and cleans up the interface a little.

We can use a zapcore.Core instance instead, but our interface would then be New() (*slog.Logger, error). Maybe that's not so bad, but it would be nice to be able to drop the error handling if possible.

[jmank88]

I think we could inline this and maybe keep it unexported until there is a need to expose it? I was worried more about multiple internal types than external.

Suggested change

	if hndlr, ok := handler.(ZapHandler); ok {
	return slog.New(hndlr.WithName(name))
	}
	return logger
	}
	type ZapHandler interface {
	WithName(string) slog.Handler
	}
	if hndlr, ok := handler.(interface { withName(string) slog.Handler }); ok {
	return slog.New(hndlr.WithName(name))
	}
	return logger
	}

[EasterTheBunny]

That works. I had it this way to run some tests, but it's not necessary.