Add aws-smithy-dns crate and HickoryDnsResolver
#4274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Needs clean up and integrating with tests
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
Aug 22, 2025
Add hickory-dns feature that enabled rt-tokio an adds hickory as a dep
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
changed the title
CachingDnsResolveraws-smithy-dns crate and HickoryDnsResolver
ysaito1001
approved these changes
Aug 25, 2025
| @@ -0,0 +1,37 @@ | |||
| [package] | |||
| name = "aws-smithy-dns" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Nice, can start as unstable.
aajtodd
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add an optional in-memory
HickoryDnsResolvertoaws-smithy-runtime. This is mostly targeted at supporting customers on AL2023 since it has disabled OS level DNS caching by default. Hyper relies on OS DNS caching if no DNS resolver is provided and this has led to some DNS throttling for users. See links below for examples:We leverage the hickory-resolver crate to provide this functionality.
Description
Add new
HickoryDnsResolverunderaws_smithy_dns. This wraps ahickory_resolver::Resolverand provides some minimal configuration options (timeouts, retries, etc.) that seem unlikely to ever go away even though thehickory-dnsecosystem is still pre-1x.Testing
Added new integration tests at
tests/hickory.rs. These tests spin up an in-process DNS server on a random port and query it overlocalhost.Had to fix
CrateSetTest.ktsince the TOML library we use in Kotlin won't parse Cargo.toml files withcfgstatements like[target.'cfg(not(target_family = "wasm"))'.dependencies]. I had to add one of those statements to preventhickory-resolverfrom being compiled for WASM targets since it was introducing a tokio feature that caused compilation to fail and that causedaws-smithy-runtimeto fail in the stability test.Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.