Skip to content

onCanvasReady event listener #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025
Merged

onCanvasReady event listener #93

merged 5 commits into from
Apr 11, 2025

Conversation

ian-wd
Copy link

@ian-wd ian-wd commented Apr 4, 2025

Draw path after onCanvasReady

oncanvas-ready.mp4

@iBotPeaches iBotPeaches requested a review from Copilot April 4, 2025 11:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • ios/RNSketchCanvasViewComponent.mm: Language not supported
  • ios/SketchCanvas/RNSketchCanvas.m: Language not supported
Comments suppressed due to low confidence (2)

android/src/main/java/com/sourcetoad/reactnativesketchcanvas/SketchCanvas.kt:429

  • Verify through tests that the onCanvasReady event is dispatched exactly once during canvas initialization to prevent accidental duplicate notifications.
if (!mIsCanvasInitialized) {

android/src/main/java/com/sourcetoad/reactnativesketchcanvas/RNTSketchCanvasManager.kt:40

  • Ensure tests cover the scenario when a command is received while the canvas is not ready, as the current implementation only logs a message.
if (root.getSketchCanvas().isCanvasReady()) {

@ian-wd ian-wd force-pushed the canvas-ready-event branch from a6becbf to ec9ee4e Compare April 7, 2025 08:15
@ian-wd ian-wd marked this pull request as ready for review April 11, 2025 08:13
@ian-wd ian-wd changed the title [WIP] onCanvasReady event listener onCanvasReady event listener Apr 11, 2025
@iBotPeaches iBotPeaches requested a review from nemanjar7 April 11, 2025 12:28
@iBotPeaches iBotPeaches merged commit 9981672 into master Apr 11, 2025
1 check passed
@iBotPeaches iBotPeaches deleted the canvas-ready-event branch April 11, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants