Handle illegal xml char #98
Conversation
|
@codito In NUnitXmlSeralizer, I am not sure what to do with these two methods below. They both have code that is specific to NUnit framework and they are the only place we are using TestCase.Properties.
|
| @@ -242,7 +244,7 @@ private static XElement CreateTestCaseElement(TestResultInfo result) | |||
| { | |||
| var element = new XElement( | |||
| "test-case", | |||
| new XAttribute("name", result.TestCase.DisplayName), | |||
| new XAttribute("name", result.Method), | |||
There was a problem hiding this comment.
We should use result.TestCaseDisplayName to avoid regressions.
There was a problem hiding this comment.
If we use the display name, we are giving up the benefit of the adapter specific code in the core logger. At is stands, only the junit logger is using the method right now. But I thought that was the goal of the core logger.
I agree this could be a breaking change, but it seems like the right direction.
There was a problem hiding this comment.
Well, maybe this issue is going to be important. spekt/junit.testlogger#57
| <PackageReference Include="System.ValueTuple" Version="4.3.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> |
There was a problem hiding this comment.
We may need to undo this for the CI to pass.
There was a problem hiding this comment.
Yeah, I will. Its just for my dev right now
|
|
|
Open items: (1) An alternative to exposing TestProperty directly is to fix spekt/testlogger#17 via the adapter specific extensions in core testlogger. We need to resolve spekt/testlogger#17 before merging this. (2) TestCaseDisplayName and MethodFormat extensibility should be in core testlogger? |
|
Continued in #100 |
Depends on spekt/testlogger#37 to be merged then we can use the new package