Skip to content

js domain: Remove extra parentheses from function arguments and errors #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

js domain: Remove extra parentheses from function arguments and errors #13569

wants to merge 3 commits into from

Conversation

SilverRainZ
Copy link
Contributor

Close #13217.

@SilverRainZ SilverRainZ force-pushed the js-domain-parens branch 3 times, most recently from 73c1ce4 to 0bc9311 Compare May 17, 2025 07:21
@AA-Turner
Copy link
Member

Can you add tests?

@AA-Turner AA-Turner added the awaiting:response Waiting for a response from the author of this issue label May 23, 2025
@SilverRainZ
Copy link
Contributor Author

I have added a test test_js_function_parentheses_in_arguments_and_errors, is there anything I am missing?

@SilverRainZ
Copy link
Contributor Author

SilverRainZ commented May 26, 2025 •
edited
Loading

@AA-Turner Excuse me, may I ask what test is still missing? I am not familiar with Sphinx's testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting:response Waiting for a response from the author of this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter types in the JavaScript domain have erroneous brackets
2 participants
@SilverRainZ @AA-Turner