Set proper exit code when cpplint.py detects lint errors. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to run node-cpplint in shell scripts and not force them to use grunt-cpplint when that is not necessary. node-cpplint src/** || echo "The C++ lint failed with exit code $?"
MiniGod
reviewed
Feb 27, 2017
| }); | ||
| /*jslint unparam:false*/ | ||
| }); | ||
| } | ||
|
|
||
| process.on('exit', function () { | ||
| process.exit(process.exitCode); |
There was a problem hiding this comment.
No need to do this. Setting process.exitCode above is enough.
https://nodejs.org/docs/latest/api/process.html#process_process_exitcode
process.exitCode
A number which will be the process exit code, when the process [...] exits gracefully
There was a problem hiding this comment.
On node.js 0.10 this is required.
There was a problem hiding this comment.
@agirorn I suggest that your remove this now as node.js 0.10 is long out of support, The we should look at getting this landed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to run node-cpplint in shell scripts and not force
them to use grunt-cpplint when that is not necessary.
node-cpplint src/** || echo "The C++ lint failed with exit code $?"
I was unable to get the tests to work for this because I do not know how to stub process.on and reset the process.exitCode in vowsjs testing framework.