Support unrectified image output in Zed X One Source #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying Issue
Our business needs a higher magnification lens to detect small objects as part of an inspection product. To do this, we are using the Zed X One camera with custom optics. This means that, by default, the
zedxonesrc
returns an unusable video stream, since the lens calibration parameters are not defined. While we have calibrated our lens using OpenCV, we were unable to determine the appropriate file format to pass into the currentzedxonesrc
(there is documentation for the depth cameras, but not the monocular camera).While this is certainly a solvable issue, our lens does not actually introduce much distortion (due to the higher focal length). We've worked around the above issue internally by retrieving unrectified images in
zedxonesrc
. We thought other people might appreciate the same feature, so we're submitting a PR here in case the Stereolabs team feels the same.Change Description
output-rectified-image
with a default value oftrue
such that the default plugin behaviour is unchanged.sl::VIEW::LEFT
when requesting rectified images orsl::VIEW::LEFT_UNRECTIFIED
if not.Other Info
We would absolutely love a document on the appropriate formatting for the OpenCV calibration file for a Zed X One camera, if you have it available!