-
Notifications
You must be signed in to change notification settings - Fork 77
Add a new CNV VMs resources utilization dashboard #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e4776a7
to
9421a05
Compare
@moadz Hi, Please review this PR. |
/retest |
Hi, following PR: #1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml). Please add the new collected metric there and it should make the test pass. |
Hi @moadz , The PR is ready for review. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadz, sradco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sradco just need to pass CI by following Jacobs comment above + rebasing. |
+1 |
9421a05
to
4c27e4f
Compare
New changes are detected. LGTM label has been removed. |
|
/retest |
7d7b9a8
to
c0345e9
Compare
|
Signed-off-by: Shirly Radco <[email protected]>
c0345e9
to
a6e64fc
Compare
@sradco: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds a new dashboard that reports the VMs resources utilization.
Signed-off-by: Shirly Radco [email protected]