Skip to content

Add a new CNV VMs resources utilization dashboard #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Feb 24, 2025

This PR adds a new dashboard that reports the VMs resources utilization.

Signed-off-by: Shirly Radco [email protected]

@sradco sradco force-pushed the add_vm_utilization_dashboard branch from e4776a7 to 9421a05 Compare February 25, 2025 07:05
@sradco
Copy link
Contributor Author

sradco commented Feb 25, 2025

@moadz Hi, Please review this PR.
I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.

@jacobbaungard
Copy link
Contributor

/retest

@jacobbaungard
Copy link
Contributor

@moadz Hi, Please review this PR. I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.

Hi, following PR: #1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml).

Please add the new collected metric there and it should make the test pass.

@sradco
Copy link
Contributor Author

sradco commented Mar 18, 2025

Hi @moadz , The PR is ready for review.

@sradco
Copy link
Contributor Author

sradco commented Mar 18, 2025

/retest

Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadz
Copy link
Contributor

moadz commented Mar 18, 2025

@sradco just need to pass CI by following Jacobs comment above + rebasing.

@sradco
Copy link
Contributor Author

sradco commented Mar 18, 2025

+1
@moadz I added the metrics to both locations

@sradco sradco force-pushed the add_vm_utilization_dashboard branch from 9421a05 to 4c27e4f Compare March 24, 2025 08:52
@openshift-ci openshift-ci bot removed the lgtm label Mar 24, 2025
Copy link

openshift-ci bot commented Mar 24, 2025

New changes are detected. LGTM label has been removed.

@jacobbaungard
Copy link
Contributor

/retest

@sradco sradco force-pushed the add_vm_utilization_dashboard branch 2 times, most recently from 7d7b9a8 to c0345e9 Compare May 5, 2025 07:10
Copy link

sonarqubecloud bot commented May 5, 2025

@sradco sradco force-pushed the add_vm_utilization_dashboard branch from c0345e9 to a6e64fc Compare May 13, 2025 09:04
Copy link

openshift-ci bot commented May 13, 2025

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pr-image-mirror-metrics-collector a6e64fc link true /test pr-image-mirror-metrics-collector
ci/prow/pr-image-mirror-rbac-query-proxy a6e64fc link true /test pr-image-mirror-rbac-query-proxy
ci/prow/pr-image-mirror-endpoint-monitoring-operator a6e64fc link true /test pr-image-mirror-endpoint-monitoring-operator
ci/prow/pr-image-mirror-grafana-dashboard-loader a6e64fc link true /test pr-image-mirror-grafana-dashboard-loader
ci/prow/pr-image-mirror-multicluster-observability-operator a6e64fc link true /test pr-image-mirror-multicluster-observability-operator
ci/prow/test-e2e a6e64fc link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants