[ACM-17966] Namespace right sizing recommendation changes #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

rajusem wants to merge 15 commits into stolostron:main from rajusem:namespace-right-sizing-recommendation

+3,913 −35

rajusem commented Apr 10, 2025 •

edited

Loading

This PR helps to enable namespaceRightSizingRecommendation feature with MCO. User can enable it by updating CRD as below.

kind: MultiClusterObservability
metadata:
  name: observability
spec:
  capabilities:
    platform:
      analytics:
        namespaceRightSizingRecommendation:
          enabled: true

Epic - https://issues.redhat.com/browse/ACM-17966

Signed-off-by: Raj Zalavadia [email protected]

openshift-ci bot added the dco-signoff: no label

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajusem
Once this PR has been reviewed and has the lgtm label, please assign saswatamcode for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tremes reviewed

View reviewed changes

...robservability/controllers/multiclusterobservability/multiclusterobservability_controller.go Outdated Show resolved Hide resolved

tremes reviewed

View reviewed changes

...lity/controllers/multiclusterobservability/analytics/rightsizing_namespace_prometheusrule.go Outdated

    
              			labelJoin = fmt.Sprintf(`* on (namespace) group_left() (%s or kube_namespace_labels{label_env=""})`, selector)

              		} else if len(l.ExclusionCriteria) > 0 {

              			selector := fmt.Sprintf(`kube_namespace_labels{label_env!~"%s"}`, strings.Join(l.ExclusionCriteria, "|"))

              			labelJoin = fmt.Sprintf(`* on (namespace) group_left() (%s or kube_namespace_labels{label_env=""})`, selector)

Contributor

tremes Apr 10, 2025

nit: the value of the labelJoin is the same in both branches so it could be moved out of the if/else

tremes reviewed

View reviewed changes

...bservability/controllers/multiclusterobservability/analytics/rightsizing_namespace_policy.go Outdated Show resolved Hide resolved

tremes reviewed

View reviewed changes

...bservability/controllers/multiclusterobservability/analytics/rightsizing_namespace_policy.go Outdated Show resolved Hide resolved

tremes reviewed

View reviewed changes

...bservability/controllers/multiclusterobservability/analytics/rightsizing_namespace_policy.go Outdated Show resolved Hide resolved

tremes reviewed

View reviewed changes

...rvability/controllers/multiclusterobservability/analytics/rightsizing_namespace_configmap.go Outdated Show resolved Hide resolved

tremes reviewed

View reviewed changes

...bservability/controllers/multiclusterobservability/analytics/rightsizing_namespace_policy.go Outdated Show resolved Hide resolved

openshift-merge-robot added the needs-rebase label

tremes reviewed

View reviewed changes

operators/multiclusterobservability/api/v1beta2/multiclusterobservability_types.go Outdated Show resolved Hide resolved

dvandra force-pushed the namespace-right-sizing-recommendation branch from 4cca272 to 8a43d3e Compare

April 28, 2025 08:52

openshift-merge-robot removed the needs-rebase label

rajusem force-pushed the namespace-right-sizing-recommendation branch from 8a43d3e to ed00670 Compare

April 29, 2025 06:21

openshift-ci bot added dco-signoff: yes and removed dco-signoff: no labels

openshift-merge-robot added the needs-rebase label

rajusem force-pushed the namespace-right-sizing-recommendation branch from ed00670 to bca3d46 Compare

April 29, 2025 06:34

openshift-merge-robot removed the needs-rebase label

openshift-ci bot added dco-signoff: no and removed dco-signoff: yes labels

rajusem force-pushed the namespace-right-sizing-recommendation branch from 0081dc8 to 769e583 Compare

April 29, 2025 13:43

openshift-ci bot added dco-signoff: yes and removed dco-signoff: no labels

rajusem force-pushed the namespace-right-sizing-recommendation branch 6 times, most recently from 0bc2fb2 to e7bde48 Compare

May 2, 2025 04:31

dvandra force-pushed the namespace-right-sizing-recommendation branch 2 times, most recently from 80b4398 to edd9103 Compare

May 13, 2025 12:08

rajusem force-pushed the namespace-right-sizing-recommendation branch 2 times, most recently from 71118df to 4553689 Compare

May 14, 2025 05:10

dvandra force-pushed the namespace-right-sizing-recommendation branch 5 times, most recently from d924704 to 6bb3c36 Compare

May 14, 2025 10:20

rajusem changed the title ~~[WIP][ACM-17966] Namespace right sizing recommendation changes~~ [ACM-17966] Namespace right sizing recommendation changes

openshift-ci bot removed the do-not-merge/work-in-progress label

rajusem and others added 14 commits

May 14, 2025 16:42


          Added AnalyticCapabilitiesSpec inside types

928043d

Signed-off-by: Raj Zalavadia <[email protected]>


          Added analytics controller class and logic to create default configmap

e3e0323

Signed-off-by: Raj Zalavadia <[email protected]>


          Added namespace rightsizing metrics into allowed list configuration

73d1d1b

Signed-off-by: Raj Zalavadia <[email protected]>


          Added grafana dashboard and related configuration

e0a2126

Signed-off-by: Raj Zalavadia <[email protected]>


          Updated manifests

5013f12

Signed-off-by: Raj Zalavadia <[email protected]>


          Adde configmap predicate function as well as logic to create Policy

a421ee2

Signed-off-by: Raj Zalavadia <[email protected]>


          Craete Placement and PlacementBinding logic

0cd6185

Signed-off-by: Raj Zalavadia <[email protected]>


          Added delete resource functionality

c0f66bc

Signed-off-by: Raj Zalavadia <[email protected]>


          Fixed placement binding issue as well as restructure configmap

Signed-off-by: Raj Zalavadia <[email protected]>


          Removed commented/unnecessary code

735bab0

Signed-off-by: Raj Zalavadia <[email protected]>


          add prometheus_rule fucntion

442d444

Signed-off-by: Raj Zalavadia <[email protected]>


          keep only one namespace inclusion or exclusion criteria

1e89779

Signed-off-by: Raj Zalavadia <[email protected]>


          Modularized Rightsizing codebase

6fe1009

Signed-off-by: Raj Zalavadia <[email protected]>


          update reviews and comments and add test-cases Corrected logs and fix…

3434bbb

…ed couple of CI issues

Signed-off-by: Darshan Vandra <[email protected]>
Signed-off-by: Raj Zalavadia <[email protected]>

dvandra force-pushed the namespace-right-sizing-recommendation branch 2 times, most recently from c187886 to ea36b45 Compare

May 14, 2025 13:03


          Fix review comment/CI issue, namespacebinding flow correction

21b98cf

Signed-off-by: Darshan Vandra <[email protected]>
Signed-off-by: Raj Zalavadia <[email protected]>

dvandra force-pushed the namespace-right-sizing-recommendation branch from ea36b45 to 21b98cf Compare

May 14, 2025 13:21

openshift-ci bot commented May 14, 2025

@rajusem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kind	`21b98cf`	link	true	`/test e2e-kind`
ci/prow/test-e2e	`21b98cf`	link	true	`/test test-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes