Skip to content

issue-34: add replace_empty_with_zero parameter for Cloudwatch metrics #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mortinke
Copy link
Contributor

No description provided.

@epwalsh
Copy link
Member

epwalsh commented Sep 30, 2019

@Mortinke thanks for this! This looks like a reasonable solution. I'm wondering though if it would be better to make it more general and have something like a default parameter instead of the replace_empty_with_zeros parameter.

@Mortinke
Copy link
Contributor Author

Mortinke commented Oct 8, 2019

@epwalsh: sorry, I missed your comment. I am on vacation with bad internet connection until 01.11. Then I'll take a look at it again.

@Mortinke
Copy link
Contributor Author

@epwalsh: Unfortunately I didn't make it earlier - other priorities in other projects :(
Can you look over the PR again? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants