Skip to content

Fixes many existing unit tests and enables PR unit test workflow #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kevinfjiang
Copy link

Tests not fixed:

OMOP and eICU datasets inherit from a deprecated base class that has had a majority of its functionality stripped away. Those datasets are non-functional and unittests will be reenabled at a later date
test_mortality_prediction relies on datasets that are require additional credentials to view. These unit tests are skipped for now until a solution on how to solve the credentials issue is implemented

Closes: #425
Closes: #338

The github actions script ran correctly according to the following action link which ran when I created a pull request from the branch feat/pr_test to master

This obsoletes #514 since I had to make some manually resolves merge conflicts

@jhnwu3
Copy link
Collaborator

jhnwu3 commented Aug 4, 2025

Hey Kevin, thanks for the effort, just a heads-up, we've moved towards all of the usual tests into tests/core. Paul helped us setup an automated CI. Let us know if this helps redirect some of the efforts since we definitely would like to have a more comprehensive usable set of test cases.

Oh btw, join us on Discord if you'd like to chat more. It's easier for us and we're more accessible as the pull requests section of GitHub is kind of a mess atm.

@jhnwu3 jhnwu3 added the Highlight for TAs to highlight label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight for TAs to highlight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Tests Add unittests & GitHub Actions
2 participants