fix: exclude bucket type in response for storage-py < 0.12.1 and supabase-py < 2.18.0 #746
+44
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Only considers storage-py (storage3) version but not supabase-py version when omitting type property
What is the new behavior?
Check both storage-py user-agent (
supabase-py/storage3 v0.12.1
) and supabase-py client-info header (supabase-py/2.18.0
) versions for a more dependable resultAdditional context
This is a workaround for a client lib issue that causes a fatal error in versions of storage-py < v0.12.1 which is part of supabase-py < 2.18.0
This is an update to #744 which only checks for storage-py (storage3) user-agent header, but not explicitly for the supabase-py client-info header