Skip to content

fix: exclude bucket type in response for storage-py < 0.12.1 and supabase-py < 2.18.0 #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itslenny
Copy link
Contributor

@itslenny itslenny commented Aug 8, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Only considers storage-py (storage3) version but not supabase-py version when omitting type property

What is the new behavior?

Check both storage-py user-agent ( supabase-py/storage3 v0.12.1 ) and supabase-py client-info header ( supabase-py/2.18.0 ) versions for a more dependable result

Additional context

This is a workaround for a client lib issue that causes a fatal error in versions of storage-py < v0.12.1 which is part of supabase-py < 2.18.0

This is an update to #744 which only checks for storage-py (storage3) user-agent header, but not explicitly for the supabase-py client-info header

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16834349833

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
  • 174 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.6%) to 76.24%

Files with Coverage Reduction New Missed Lines %
src/http/routes/bucket/emptyBucket.ts 8 84.91%
src/internal/errors/codes.ts 14 70.31%
src/storage/database/knex.ts 23 81.15%
src/http/routes/object/getPublicObject.ts 26 66.67%
src/storage/storage.ts 26 66.76%
src/storage/events/objects/object-admin-delete-all-before.ts 77 18.44%
Totals Coverage Status
Change from base Build 16812027565: -0.6%
Covered Lines: 20849
Relevant Lines: 27113

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants