-
Notifications
You must be signed in to change notification settings - Fork 204
[feat] using exporter-toolkit/web for web config #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: reboot
Are you sure you want to change the base?
[feat] using exporter-toolkit/web for web config #2165
Conversation
I like the idea of embedding webconfig into the config. It is one less configuration to worry about. Let me play around it a bit and get back to you. Just a nit: ... This PR will be a |
d177438
to
ff6cd04
Compare
ff6cd04
to
fa081d9
Compare
Signed-off-by: SamYuan1990 <[email protected]>
fa081d9
to
9c68f7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reboot #2165 +/- ##
==========================================
+ Coverage 91.51% 92.05% +0.53%
==========================================
Files 36 36
Lines 3490 3612 +122
==========================================
+ Hits 3194 3325 +131
+ Misses 229 224 -5
+ Partials 67 63 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I just make some update in code and fix with test cases. |
Let's use this PR to discuss how we integrate with exporter-toolkit/web.
From exporter-toolkit/web SDK, we need
*web.FlagConfig
structure ready before we start the server.but the question here is how we make it in our configuration and code structure.
we now have config in yaml file and those flag reg in same pattern, if we fully moved to exporter-toolkit/web as one example impl in this PR shows.
We still need all config in one place, so that it will not impact main.go, but somehow breaks config.go in yaml and flag reg process.
The benefits here IMO, is that we can leave web config to upstream repo for feature supports and it seems for an exporter we don't need to support listen on multi socket, so... just a default port and default TLS config file will be good enough.