-
Notifications
You must be signed in to change notification settings - Fork 204
ci: ensure that all the commits are linted by pre-commit hook #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ensure that all the commits are linted by pre-commit hook #2181
Conversation
cd76b97
to
7d9fca7
Compare
CI fails when the commit message doesn't follow the convention: https://github.com/sustainable-computing-io/kepler/actions/runs/15822470386/job/44594680029?pr=2181#step:6:38
|
9e6e6b7
to
7d9fca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vprashar2929 could you please add a set of commits E.g.
- valid
- invalid
- valid
- invaliid
- valid
And check if this PR correctly identifies the invalid commits
7d9fca7
to
208e538
Compare
bfbb9b5
to
76ded09
Compare
76ded09
to
53f417e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2181 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 37 37
Lines 3809 3809
=======================================
Hits 3516 3516
Misses 233 233
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit ensures that all the commits are linted by pre-commit hook in a PR. Signed-off-by: vprashar2929 <[email protected]>
4775f3f
to
8da4eff
Compare
2bf775f
to
8da4eff
Compare
@sthaha commitlint hooks only lint the current commit message during commit creation. Hence we cannot use them for linting all commit messages in a PR. To ensure linter runs on all PR commits we have to use the commitlint directly and not via pre-commit hooks. |
This commit ensures that all the commits are linted by pre-commit hook in a PR.