Skip to content

ci: ensure that all the commits are linted by pre-commit hook #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

vprashar2929
Copy link
Collaborator

This commit ensures that all the commits are linted by pre-commit hook in a PR.

@github-actions github-actions bot added the ci Changes to the CI pipeline label Jun 23, 2025
@vprashar2929 vprashar2929 force-pushed the ci-comm-lint branch 3 times, most recently from cd76b97 to 7d9fca7 Compare June 23, 2025 06:42
@github-actions github-actions bot added the chore Routine tasks or maintenance label Jun 23, 2025
@vprashar2929
Copy link
Collaborator Author

vprashar2929 commented Jun 23, 2025

CI fails when the commit message doesn't follow the convention: https://github.com/sustainable-computing-io/kepler/actions/runs/15822470386/job/44594680029?pr=2181#step:6:38
even if there are multiple commits in a PR

chore: Update Makefile

Signed-off-by: vprashar2929 <[email protected]>

ci: ensure that all the commits are linted by pre-commit hook

This commit ensures that all the commits are linted by pre-commit hook
in a PR.

Signed-off-by: vprashar2929 <[email protected]>

@github-actions github-actions bot removed the chore Routine tasks or maintenance label Jun 23, 2025
@vprashar2929 vprashar2929 requested a review from sthaha June 23, 2025 11:35
Copy link
Collaborator

@sthaha sthaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vprashar2929 could you please add a set of commits E.g.

  1. valid
  2. invalid
  3. valid
  4. invaliid
  5. valid

And check if this PR correctly identifies the invalid commits

@github-actions github-actions bot added the test Adding or updating tests label Jun 25, 2025
@github-actions github-actions bot removed the test Adding or updating tests label Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (0d0ca5f) to head (4775f3f).

Additional details and impacted files
@@           Coverage Diff           @@
##           reboot    #2181   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          37       37           
  Lines        3809     3809           
=======================================
  Hits         3516     3516           
  Misses        233      233           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This commit ensures that all the commits are linted by pre-commit hook
in a PR.

Signed-off-by: vprashar2929 <[email protected]>
@github-actions github-actions bot added the test Adding or updating tests label Jun 25, 2025
@github-actions github-actions bot removed the test Adding or updating tests label Jun 25, 2025
@vprashar2929
Copy link
Collaborator Author

@sthaha commitlint hooks only lint the current commit message during commit creation. Hence we cannot use them for linting all commit messages in a PR. To ensure linter runs on all PR commits we have to use the commitlint directly and not via pre-commit hooks.
Ref: https://github.com/sustainable-computing-io/kepler/actions/runs/15867506943/job/44737088248?pr=2181

@sthaha sthaha merged commit ffdfb2b into sustainable-computing-io:reboot Jun 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants