-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: update instructions for assets-only workers #14238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
2b060dc
to
43ec2a4
Compare
@@ -237,7 +237,7 @@ export default config; | |||
/// file: wrangler.toml | |||
---site.bucket = ".cloudflare/public"--- | |||
+++assets.directory = ".cloudflare/public" | |||
assets.binding = "ASSETS"+++ | |||
assets.binding = "ASSETS" # Add this binding only if you have Worker scripts+++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this works so that the comment doesn't get highlighted
assets.binding = "ASSETS" # Add this binding only if you have Worker scripts+++ | |
assets.binding = "ASSETS"+++ # Add this binding only if you have Worker scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this but it highlighted the full line anyways, so I reverted it to the original version with the +++
at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no worries. There's a PR to try and fix the highlighting sveltejs/svelte.dev#1480 but it's not ready yet and this isn't that important
As mentioned in #14018, assets-only workers should not have
assets.binding
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits