Skip to content

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Aug 16, 2025

As mentioned in #14018, assets-only workers should not have assets.binding.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@svelte-docs-bot
Copy link

Copy link

changeset-bot bot commented Aug 16, 2025

⚠️ No Changeset found

Latest commit: 1db17fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kevinji kevinji changed the title fix(docs): update instructions for assets-only workers fix: update instructions for assets-only workers Aug 16, 2025
@eltigerchino eltigerchino added documentation Improvements or additions to documentation pkg:adapter-cloudflare labels Aug 19, 2025
@eltigerchino eltigerchino changed the title fix: update instructions for assets-only workers docs: update instructions for assets-only workers Aug 19, 2025
@kevinji kevinji force-pushed the patch-2 branch 3 times, most recently from 2b060dc to 43ec2a4 Compare August 20, 2025 04:44
@@ -237,7 +237,7 @@ export default config;
/// file: wrangler.toml
---site.bucket = ".cloudflare/public"---
+++assets.directory = ".cloudflare/public"
assets.binding = "ASSETS"+++
assets.binding = "ASSETS" # Add this binding only if you have Worker scripts+++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this works so that the comment doesn't get highlighted

Suggested change
assets.binding = "ASSETS" # Add this binding only if you have Worker scripts+++
assets.binding = "ASSETS"+++ # Add this binding only if you have Worker scripts

Copy link
Contributor Author

@kevinji kevinji Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this but it highlighted the full line anyways, so I reverted it to the original version with the +++ at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no worries. There's a PR to try and fix the highlighting sveltejs/svelte.dev#1480 but it's not ready yet and this isn't that important

@eltigerchino eltigerchino merged commit 948d6c8 into sveltejs:main Aug 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg:adapter-cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants