Skip to content

fix highlighting #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix highlighting #1480

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ad171e
fix highlighting
Rich-Harris Aug 17, 2025
353c798
Merge branch 'main' into fix-highlighting
eltigerchino Aug 19, 2025
27c8538
Merge branch 'main' into fix-highlighting
Ocean-OS Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/site-kit/src/lib/markdown/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,11 +719,18 @@ function replace_blank_lines(html: string) {
}

const delimiter_substitutes = {
'---': ' ',
'+++': ' ',
':::': ' '
'---': ' ',
'+++': ' ',
':::': ' '
};

const delimiter_patterns = Object.fromEntries(
Object.entries(delimiter_substitutes).map(([key, substitute]) => [
key,
new RegExp(`${substitute}([^ ][^]+?)${substitute}`, 'g')
])
);

function highlight_spans(content: string, classname: string) {
return content
.split('\n')
Expand Down Expand Up @@ -878,13 +885,13 @@ async function syntax_highlight({
.replace(' tabindex="0"', '');

html = html
.replace(/ {13}([^ ][^]+?) {13}/g, (_, content) => {
.replace(delimiter_patterns['---'], (_, content) => {
return highlight_spans(content, 'highlight remove');
})
.replace(/ {11}([^ ][^]+?) {11}/g, (_, content) => {
.replace(delimiter_patterns['+++'], (_, content) => {
return highlight_spans(content, 'highlight add');
})
.replace(/ {9}([^ ][^]+?) {9}/g, (_, content) => {
.replace(delimiter_patterns[':::'], (_, content) => {
return highlight_spans(content, 'highlight');
});

Expand Down