-
Notifications
You must be signed in to change notification settings - Fork 81
Unified logging setup for Swift extension #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thanks! Just some minor typo suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! This will help a lot with our logging.
Just one minor comment about the name of the setting.
Description
winston
dependency that will log to a file always, and to theSwift
output channel at the level specified by the newswift.outputChannelLevel
settingswift.diagnostics
setting but check it to set the output channel todebug
if theswift.outputChannelLevel
setting is not explicitly setRollingLog
to hold log messages in memory unless running the extension under testsSwiftOutputChannel
used by the LSP to extend this new login functionality, but allow it to be treated like an output channelIssue: #1755
Tasks
Documentation has been updated