Prompt to restart SourceKit-LSP on config changes #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
reviewed
Aug 1, 2025
|
Thank you for the review. I need to update some tests (this change makes it flaky now) and will add a test, so will move this to draft temporarily. |
Check that a LSP restart prompt is shown when the config.json file is changed and update existing tests that modify the file to ignore the LSP restart prompts.
rbenegal
force-pushed
the
restart_lsp_for_config_changes
branch
from
584e3bc to
fe4df34
Compare
plemarquand
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prompts the user if they want to restart SourceKit-LSP after changing the
config.jsonfile.Issue: #1744
Tasks