Skip to content

android: add selection of included/excluded apps in split tunneling #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davfsa
Copy link

@davfsa davfsa commented Mar 13, 2025

Hello!

I took a stab at adding the ability to select included/excluded apps from App Split Tunneling instead of only allowing selecting excluded applications.

Included apps view Excluded apps view Selected apps reset alert

All images are 1280x2856, so you can open them in a new tab to view them better


A couple of points:

  • DISALLOWED_APPS_KEY (now SELECTED_APPS_KEY) is in a bit of a weird situation as the value no longer represents the variable name. I havent opted to add a migration flow for the key, but can be done if needed. For now I have just added a comment above explaining the the reason
  • switchUserSelectedPackages is not the best of names, but I couldn't come up with any better, will update with any suggestions or if I come up with a better one
  • This is my first real work with Android JetPack and Android in general, so if there are any rookie mistakes, that would be why 🙃. If anything needs to be changed, I will get to it as soon as possible!

Closes tailscale/tailscale#14660

@davfsa davfsa force-pushed the task/improve-app-split-tunneling-feature branch from 91cf3af to fbcd071 Compare March 13, 2025 00:11
@davfsa davfsa changed the title Add ability to select included/excluded apps from App Split Tunneling android: Add ability to select included/excluded apps from App Split Tunneling Mar 13, 2025
@davfsa davfsa changed the title android: Add ability to select included/excluded apps from App Split Tunneling android: add selection of included/excluded apps in split tunneling Mar 13, 2025
Copy link

review-ai-agent bot commented Apr 21, 2025

Pull Request Revisions

RevisionDescription
r4
Log level and package name updatesModified log levels, replaced hardcoded package name with BuildConfig.APPLICATION_ID, and corrected log messages in several files
r3
Refactored package name referencesReplaced BuildConfig.APPLICATION_ID with hardcoded "com.tailscale.ipn" string and updated related logging messages
r2
Replaced hardcoded package name referencesUpdated multiple source files to use BuildConfig.APPLICATION_ID instead of hardcoded "com.tailscale.ipn" package name references
r1
Enhanced app split tunneling functionalityRefactored split tunneling to support both include and exclude app routing modes, with new toggle and warning dialog functionality
✅ AI review completed for r4
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@davfsa davfsa force-pushed the task/improve-app-split-tunneling-feature branch from 944d0f8 to 6b210ba Compare April 21, 2025 14:51
@davfsa
Copy link
Author

davfsa commented Apr 21, 2025

Hey @barnstar, sorry for the ping, but its been a little while, would it be possible to get a review?

Thanks! And again, sorry for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: App split tunneling feature
1 participant