schema: move 'concurrent schema update' error to constants #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
force-pushed
the
bigbes/TNTP-3336-move-err-to-constant
branch
from
bfd201c to
769e90a
Compare
oleg-jukovec
requested changes
Jul 1, 2025
There was a problem hiding this comment.
I suggest to change the commit title too:
const: add 'concurrent schema update' error constant
Up to you.
Please, add a unit-test for the constant that checks that it value is "concurrent schema update". This test will help to fix this behavior (error string).
bigbes
force-pushed
the
bigbes/TNTP-3336-move-err-to-constant
branch
from
769e90a to
f17afe9
Compare
bigbes
force-pushed
the
bigbes/TNTP-3336-move-err-to-constant
branch
from
f17afe9 to
ed88a1d
Compare
bigbes
force-pushed
the
bigbes/TNTP-3336-move-err-to-constant
branch
2 times, most recently
from
5bc3968 to
5ddbf80
Compare
oleg-jukovec
approved these changes
Jul 1, 2025
|
If we have an issue on GitHub, then it is a good idea to provide a link to it. In this case, a link to ticket in Jira is a good idea, but not required. -> or |
oleg-jukovec
requested changes
Jul 1, 2025
Closes #404, TNTP-3336
bigbes
force-pushed
the
bigbes/TNTP-3336-move-err-to-constant
branch
from
5ddbf80 to
780841e
Compare
oleg-jukovec
approved these changes
Jul 1, 2025
dmyger
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #404, TNTP-3336