feat: setup media matching [WIP] #784
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennyabrain
reviewed
May 28, 2025
| @python_path Path.expand("lib/python") | ||
|
|
||
| def get_embedding(file_path) do | ||
| {:ok, py} = Python.start(python_path: @python_path) |
There was a problem hiding this comment.
this might be something you do in an init function.
my sense is that you can create a port that talks to the python process and keep it open. This py has to be a reference to that port. so best to create it once and then use throughout the functions that talk to the port.
There was a problem hiding this comment.
how do I do that in elixir? sorry I am bit confused
There was a problem hiding this comment.
I am proposing creating a new function init_worker
def init_worker() do
{:ok, py} = Python.start(python_path: @python_path)
py
endand then the calling code can pass py to other functions in this module that might need it. for example Python.call(py ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #750