MintStore Input Fix (?) #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zir0h
approved these changes
Mar 8, 2025
|
do you have some scenario's to test? would be good to see a before/after |
|
The scenario I encountered was when I would check the preview page before mint, realized needed edits, but when hitting the back button erased all the changes I made prior. It's been a while so don't remember a lot of it but I think it's fixed now? |
Zir0h
pushed a commit
to josim/teia-ui
that referenced
this pull request
May 25, 2025
Zir0h
pushed a commit
to josim/teia-ui
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the default values of the Form with mintStore, rather than the defaultValues, which was overwriting the user's input in certain cases
Removed console logs and key errors from the CustomCopyrightForm
I think it's working but needs to be tested for stability.