Skip to content

[Feature✨] Add curation tab to user profile #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025

Conversation

floydwilde
Copy link
Contributor

Summary

  • list curated tokens a user is reselling
  • expose new page from profile tabs and routing

I used ChatGPT Codex to generate the code. I rebuilt my container using the branch and checked locally, it seems to work:

Screenshot from 2025-05-20 23-02-28

These are NFTs I've collected, am not the owner of, and offering for sale. I've mentioned adding this feature to @Zir0h in the feature request channel a while ago.

Copy link
Contributor

@Zir0h Zir0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Zir0h
Copy link
Contributor

Zir0h commented May 20, 2025

deployed on https://preview.teia.art/

@NoRulesJustFeels
Copy link
Contributor

If a user doesn't have any curated tokens it displays: "no curated tokens"
But its not clear how a user would get or show curated tokens. Would it make sense to explain curation on this page or link to a wiki/help page?

@floydwilde floydwilde changed the title Add curation tab to user profile [Feature✨] Add curation tab to user profile May 20, 2025
@floydwilde
Copy link
Contributor Author

If the change is deployed, I'll go add something on the wiki, probably on this page for starters:

Mention that items which you collect and offer for sale will turn up on your "curation" page.

@Zir0h
Copy link
Contributor

Zir0h commented May 20, 2025

some parts of the wiki were added to the main site with e69a904 I think, maybe it's time to move everything else over as well?

@floydwilde
Copy link
Contributor Author

floydwilde commented May 20, 2025

Eww, could we hit pause on moving any more docs to the UI? If this change is merged, I would be happy to go to the two places where this is documented now. One is a kind of weird docs site that will at least automatically add anchor tags for headings like this:

The other is a self-managed, not very featureful markdown page with no auto-anchor tags:

Trust me the heading is on that page, just do ctrl-F in your browser and search for the text "How Can I Track What I've Sold?".

I'm cheekily thinking about putting a heading: "How Can I Track What I'm Selling?"

@floydwilde
Copy link
Contributor Author

That process is more like, search for this bit of text on the faq page:

"How do I resell an Objkt?"

Click it, it's some kind of accordion thing that hides the text.

Then search for the actual heading I wanted you to look at. Or just go to the wiki, that page is probably more up to date.

@Zir0h
Copy link
Contributor

Zir0h commented May 24, 2025

I agree the accordion thingy is a bit annoying and should be removed, but the feedback we usually get is that people don't even find the weird documentation site with the auto anchors 😅 That's why some information was move into the UI.

Maybe a little (?) here and there with a link to the docs site could be a good alternative? I don't know, I hate frontend.

@floydwilde
Copy link
Contributor Author

Yeah, I would like to organise a migration to Docusaurus for the docs, and integrate that with the site theme. I find it difficult to believe users want to use the Teia UI to read documentation. And I fear it will be neglected and out of date once it does arrive there. For some docs, related to the DAO etc... it's nice to have the possibility of a peer review process, which GitHub helps facilitate, and Docusaurus which is built around Git also facilitates.

Our volunteer developers can not keep pace with the enhancements to the Documentation experience (creating and consuming) that Docusaurus provides. There is other tooling like Sphinx, MkDocs, Gitbook etc... we should consider, but it was someone else who suggested Docusaurus a few years ago, and I looked into it a bit, and it does seem to make sense.

I don't think the docs issue should stand in the way of adding the curation tab though. This is also something I've wanted and is an enhancement to the community because right now, there is not a good way to see what part of your collection is offered for resale. There is this idiosyncratic thing we are doing w/ the C words, I think of it as the C group on that profile tab menu. Which makes it unique to Teia.

@Zir0h Zir0h merged commit 9a59522 into teia-community:main May 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants