-
Notifications
You must be signed in to change notification settings - Fork 38
[Feature✨] Add curation tab to user profile #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e-and-guide Add curation tab to user profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
deployed on https://preview.teia.art/ |
If a user doesn't have any curated tokens it displays: "no curated tokens" |
If the change is deployed, I'll go add something on the wiki, probably on this page for starters: Mention that items which you collect and offer for sale will turn up on your "curation" page. |
some parts of the wiki were added to the main site with e69a904 I think, maybe it's time to move everything else over as well? |
Eww, could we hit pause on moving any more docs to the UI? If this change is merged, I would be happy to go to the two places where this is documented now. One is a kind of weird docs site that will at least automatically add anchor tags for headings like this: The other is a self-managed, not very featureful markdown page with no auto-anchor tags: Trust me the heading is on that page, just do ctrl-F in your browser and search for the text "How Can I Track What I've Sold?". I'm cheekily thinking about putting a heading: "How Can I Track What I'm Selling?" |
That process is more like, search for this bit of text on the faq page: "How do I resell an Objkt?" Click it, it's some kind of accordion thing that hides the text. Then search for the actual heading I wanted you to look at. Or just go to the wiki, that page is probably more up to date. |
I agree the accordion thingy is a bit annoying and should be removed, but the feedback we usually get is that people don't even find the weird documentation site with the auto anchors 😅 That's why some information was move into the UI. Maybe a little (?) here and there with a link to the docs site could be a good alternative? I don't know, I hate frontend. |
Yeah, I would like to organise a migration to Docusaurus for the docs, and integrate that with the site theme. I find it difficult to believe users want to use the Teia UI to read documentation. And I fear it will be neglected and out of date once it does arrive there. For some docs, related to the DAO etc... it's nice to have the possibility of a peer review process, which GitHub helps facilitate, and Docusaurus which is built around Git also facilitates. Our volunteer developers can not keep pace with the enhancements to the Documentation experience (creating and consuming) that Docusaurus provides. There is other tooling like Sphinx, MkDocs, Gitbook etc... we should consider, but it was someone else who suggested Docusaurus a few years ago, and I looked into it a bit, and it does seem to make sense. I don't think the docs issue should stand in the way of adding the curation tab though. This is also something I've wanted and is an enhancement to the community because right now, there is not a good way to see what part of your collection is offered for resale. There is this idiosyncratic thing we are doing w/ the C words, I think of it as the C group on that profile tab menu. Which makes it unique to Teia. |
Summary
I used ChatGPT Codex to generate the code. I rebuilt my container using the branch and checked locally, it seems to work:
These are NFTs I've collected, am not the owner of, and offering for sale. I've mentioned adding this feature to @Zir0h in the feature request channel a while ago.