Skip to content

chore: Update to use current upstream modules #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Andrews-repo
Copy link
Contributor

@Andrews-repo Andrews-repo commented Jul 29, 2025

Description
This PR updates the module to align with changes introduced in terraform-aws-modules/ecs/aws v6.x. Specifically, it updates the usage of the ECS service and cluster submodules to reflect current upstream expectations and field structures.

Motivation and Context
Align with upstream module conventions (terraform-aws-modules/ecs/aws v6.x)

Remove deprecated fields and adopt new syntax for ECS cluster and service configuration

Ensure future compatibility and reduce drift from supported patterns

Breaking Changes
Yes.

fargate_capacity_providers has been removed and replaced by default_capacity_provider_strategy, matching upstream behavior.

service_registries must now be set to null or omitted entirely — using an empty list [] will result in a type error. This aligns with upstream, which expects an object, not a list.

Some internal variable defaults and structures were updated to follow upstream expectations, which may cause errors if older formats are used without adjustment.

How Has This Been Tested?
Deployed using the updated module in a live production environment

Verified ECS service behavior and cluster creation

Please let me know if there additional changes or things needed I may of missed

@Andrews-repo Andrews-repo changed the title Update tp use current upstream modules Update to use current upstream modules Jul 29, 2025
@Andrews-repo Andrews-repo changed the title Update to use current upstream modules Chore: Update to use current upstream modules Jul 29, 2025
@Andrews-repo Andrews-repo changed the title Chore: Update to use current upstream modules chore: Update to use current upstream modules Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants