Skip to content

feat: Pipes log configuration support #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jun 8, 2024

Description

Support aws_pipes_pipe log_configuration.
Added force_destroy to aws_cloudwatch_event_target and aws_cloudwatch_event_rule.
Updated api-gateway module due to breaking major version changes.

Motivation and Context

hashicorp/terraform-provider-aws#37135
hashicorp/terraform-provider-aws#34905
hashicorp/terraform-provider-aws#37130

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum changed the title feat: Pipes logging support feat: Pipes log configuration support Jun 8, 2024
@antonbabenko
Copy link
Member

@magreenbaum Please assign a reviewer once you are done. It already looks very good to me. Thanks!

@magreenbaum magreenbaum requested a review from antonbabenko June 9, 2024 13:29
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonbabenko antonbabenko merged commit 9e21611 into terraform-aws-modules:master Jun 13, 2024
15 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 13, 2024
## [3.5.0](v3.4.0...v3.5.0) (2024-06-13)

### Features

* Pipes log configuration support ([#125](#125)) ([9e21611](9e21611))
@antonbabenko
Copy link
Member

This PR is included in version 3.5.0 🎉

@magreenbaum magreenbaum deleted the feat/pipes_logging_support branch June 15, 2024 00:38
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants