feat: add Solace pubsub+ module #3230

unicod3 · 2025-07-11T00:19:46Z

What does this PR do?

Adds a new module for Solace pubsub+

Why is it important?

Exposes a ready-to-use module for Solace Pubsub+

Related issues

Closes [Enhancement]: Add solace pubsub+ module #3229

netlify · 2025-07-11T00:19:51Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`58100c9`
🔍 Latest deploy log	https://app.netlify.com/projects/testcontainers-go/deploys/688b30dc68696a00088e0267
😎 Deploy Preview	https://deploy-preview-3230--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

mdelapenya

@unicod3 thanks for submitting this PR. I did an initial review and found some issues that need to be addressed, mostly related to the consistent patterns we apply when building the modules.

TL;DR;

no constructor for the Container type
options must be exposed at the package level, not added to the container type
Run function using functional opts

In any case, we can work with you in making it consistent, and merge it into the project. Thank you so much for your contribution

coverage.out

modules/solace/coverage.out

modules/solace/go.mod

modules/solace/solace.go

unicod3 · 2025-07-22T13:48:11Z

@unicod3 thanks for submitting this PR. I did an initial review and found some issues that need to be addressed, mostly related to the consistent patterns we apply when building the modules.

TL;DR;
* no constructor for the Container type

* options must be exposed at the package level, not added to the container type

* Run function using functional opts
In any case, we can work with you in making it consistent, and merge it into the project. Thank you so much for your contribution

@mdelapenya I've addressed them all, let me know if I missed anything, thank you for the review.

mdelapenya

Looks pretty good, thanks for your hard work! Just a few comments, and we are done 😊

modules/solace/options.go

modules/solace/service.go

modules/solace/solace.go

modules/solace/examples_test.go

modules/solace/script.go

modules/solace/solace.go

mdelapenya

LGTM! Even though I think we need to use testify in the options_test file, I'm approving this PR before hand.

Thank you for all your hard work during the review 🙇

unicod3 · 2025-07-30T14:00:46Z

LGTM! Even though I think we need to use testify in the options_test file, I'm approving this PR before hand.

Thank you for all your hard work during the review 🙇

You're welcome, enjoyed the collaboration. In my last commit, I also addressed linter issues, there is a CodeQL check failing however I am not really sure if that's because of my branch.

modules/solace/options_test.go

unicod3 · 2025-07-30T14:46:43Z

@mdelapenya just fixed the failing test issue fyi

mdelapenya · 2025-07-30T16:22:42Z

@unicod3 I added a commit on top of yours, just to refine the docs. PLMK what you think. We can merge this PR right after that.

unicod3 · 2025-07-30T16:28:17Z

@unicod3 I added a commit on top of yours, just to refine the docs. PLMK what you think. We can merge this PR right after that.

LGTM.

modules/solace/examples_test.go

Copilot

Pull Request Overview

This PR adds a new Testcontainers module for Solace Pubsub+, providing a ready-to-use container interface for testing applications that use Solace messaging services. The module supports configuration of multiple service types (AMQP, MQTT, REST, Management, SMF), queue/topic setup, and authentication options.

Key changes:

Implements core Solace container functionality with configurable options for credentials, VPN, services, and message queues
Provides service-specific URL generation for different Solace protocols (AMQP, MQTT, REST, SMF)
Includes comprehensive test coverage and examples demonstrating message publishing and consumption

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
modules/solace/solace.go	Core container implementation with Run function, service configuration, and CLI script execution
modules/solace/service.go	Service definitions for AMQP, MQTT, REST, Management, and SMF protocols
modules/solace/options.go	Configuration options for credentials, VPN, queues, services, and shared memory
modules/solace/solace_test.go	Basic integration test validating container startup and service accessibility
modules/solace/options_test.go	Unit tests for all configuration options and their combinations
modules/solace/examples_test.go	Example usage with Solace SDK integration for message publishing/consuming
modules/solace/mounts/solace.script.tpl	CLI script template for queue and topic configuration
docs/modules/solace.md	Module documentation with usage examples and API reference

Comments suppressed due to low confidence (1)

docs/modules/solace.md:54

The function name should be 'WithVPN' (all caps) to match the actual function name in the code, not 'WithVpn'.

#### WithVpn

modules/solace/options.go

mdelapenya

LGTM, thanks!

mdelapenya · 2025-07-31T10:41:47Z

@unicod3 thanks for your contribution! I'm adding it to the modules catalog right now: testcontainers/community-module-registry#147

…util/v4-4.25.6 * main: fix(dockermcpgateway): use duckduckgo instead of brave (#3247) feat: add Solace pubsub+ module (#3230) feat(options): add WithProvider (#3241) chore(deps): bump github/codeql-action from 3.29.2 to 3.29.3 (#3237) chore(deps): bump golang.org/x/oauth2 in /modules/weaviate (#3240) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.5 to 7.1.6 (#3239) chore(deps): bump requests from 2.32.0 to 2.32.4 (#3204) feat(mcpgateway): add MCP gateway module (#3232) chore(deps): bump golang.org/x/oauth2 in /modules/pulsar (#3236) chore(deps): bump golang.org/x/oauth2 in /modules/gcloud (#3235) chore(deps): bump golang.org/x/oauth2 in /modules/k3s (#3234) chore: prepare for next minor development cycle (0.39.0) chore: use new version (v0.38.0) in modules and examples Update go.mod in azure module (#3231) fix: strip headers from logs using log stream specification (#3226) chore: clarify image auth warning message for public images (#3228) chore(deps): bump github.com/go-viper/mapstructure/v2 (#3219) chore(deps): bump github/codeql-action from 3.28.16 to 3.29.2 (#3222) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.5 to 7.1.6 (#3225)

unicod3 added 2 commits July 11, 2025 00:34

feat: Add solace pubsub+ module

a6a429c

chore: Update docs

429774a

unicod3 requested a review from a team as a code owner July 11, 2025 00:19

unicod3 changed the title ~~feat: Add solace pubsub+ module~~ feat: add Solace pubsub+ module Jul 11, 2025

Merge branch 'main' into feature/solace

fd0ef3f

mdelapenya requested changes Jul 16, 2025

View reviewed changes

unicod3 and others added 9 commits July 21, 2025 17:12

Merge branch 'testcontainers:main' into feature/solace

f3b4984

Remove coverage file

d117eb0

Upgrade the version

214e5af

Apply PR suggestions

64d2f3e

Apply PR suggestions

0ab42cb

Encapsulate internal variables

7f2b222

Introduce options pattern

87a7297

Update solace.md

8b15624

Use wait package for the container script execution

e24ae01

unicod3 force-pushed the feature/solace branch from 939236d to e24ae01 Compare July 22, 2025 12:32

Update solace script

b0c452e

unicod3 force-pushed the feature/solace branch from 7bb539b to b0c452e Compare July 22, 2025 13:33

unicod3 requested a review from mdelapenya July 22, 2025 13:38

Merge branch 'main' into feature/solace

e6827ad

mdelapenya reviewed Jul 22, 2025

View reviewed changes

modules/solace/options.go Outdated Show resolved Hide resolved

modules/solace/service.go Show resolved Hide resolved

modules/solace/solace.go Outdated Show resolved Hide resolved

modules/solace/solace.go Outdated Show resolved Hide resolved

Apply PR suggestions

6869258

unicod3 requested a review from mdelapenya July 24, 2025 14:42

mdelapenya reviewed Jul 24, 2025

View reviewed changes

modules/solace/examples_test.go Outdated Show resolved Hide resolved

stevenh requested changes Jul 24, 2025

View reviewed changes

modules/solace/script.go Outdated Show resolved Hide resolved

modules/solace/solace.go Outdated Show resolved Hide resolved

modules/solace/solace.go Outdated Show resolved Hide resolved

modules/solace/solace.go Show resolved Hide resolved

unicod3 added 3 commits July 26, 2025 14:58

Apply PR suggestions

a404209

Make use of CopyToContainer method

105fb91

Replace exposed ports to WithServices

e8eaa06

mdelapenya previously approved these changes Jul 30, 2025

View reviewed changes

Fix linter issues

adb935a

unicod3 dismissed mdelapenya’s stale review via adb935a July 30, 2025 13:55

unicod3 requested review from stevenh and mdelapenya July 30, 2025 13:56

mdelapenya reviewed Jul 30, 2025

View reviewed changes

modules/solace/options_test.go Outdated Show resolved Hide resolved

Switch assert to require for tests

beafbe5

unicod3 requested a review from mdelapenya July 30, 2025 14:37

Fix image name

c165326

docs: refinements

3198a1c

mdelapenya self-assigned this Jul 31, 2025

mdelapenya added the enhancement New feature or request label Jul 31, 2025

mdelapenya previously approved these changes Jul 31, 2025

View reviewed changes

mdelapenya reviewed Jul 31, 2025

View reviewed changes

modules/solace/examples_test.go Show resolved Hide resolved

mdelapenya added 2 commits July 31, 2025 07:57

chore: add a comment for the testable example's output

df10a36

chore: move default services to a variable

07c6d2a

mdelapenya dismissed their stale review via 07c6d2a July 31, 2025 05:57

mdelapenya reviewed Jul 31, 2025

View reviewed changes

modules/solace/examples_test.go Outdated Show resolved Hide resolved

Remove sleep from the test

4fd1ed9

mdelapenya requested a review from Copilot July 31, 2025 08:59

Copilot AI reviewed Jul 31, 2025

View reviewed changes

modules/solace/options.go Outdated Show resolved Hide resolved

fix: typo

58100c9

mdelapenya approved these changes Jul 31, 2025

View reviewed changes

mdelapenya merged commit 2fb003a into testcontainers:main Jul 31, 2025
16 checks passed

Uh oh!

feat: add Solace pubsub+ module #3230

feat: add Solace pubsub+ module #3230

Uh oh!

Conversation

unicod3 commented Jul 11, 2025

What does this PR do?

Why is it important?

Related issues

Uh oh!

netlify bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for testcontainers-go ready!

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

unicod3 commented Jul 22, 2025

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdelapenya left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unicod3 commented Jul 30, 2025

Uh oh!

Uh oh!

unicod3 commented Jul 30, 2025

Uh oh!

mdelapenya commented Jul 30, 2025

Uh oh!

unicod3 commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

mdelapenya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdelapenya commented Jul 31, 2025

Uh oh!

Uh oh!

netlify bot commented Jul 11, 2025 •

edited

Loading

mdelapenya left a comment •

edited

Loading