Skip to content

def: 1-category Monad(C) #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 6, 2024
Merged

def: 1-category Monad(C) #381

merged 19 commits into from
Jun 6, 2024

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Jun 4, 2024

Description

Define the 1-category of monads.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

@Lavenza
Copy link
Member

Lavenza commented Jun 4, 2024

Pull request preview

@favonia favonia force-pushed the monads branch 2 times, most recently from e05ccd6 to 3b218f4 Compare June 4, 2024 17:18
@favonia favonia marked this pull request as ready for review June 4, 2024 17:18
@favonia
Copy link
Contributor Author

favonia commented Jun 4, 2024

This is my first serious 1lab contribution and I probably messed up things. 😅

Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

@favonia
Copy link
Contributor Author

favonia commented Jun 5, 2024

@ncfavier Question: should I write "id", "Id", or "1" for identity functors and identity natural transformations? I checked a few more pages and found that it's not entirely consistent. 🤔

@ncfavier
Copy link
Member

ncfavier commented Jun 5, 2024

"Id" is fine for functors, and "id" for natural transformations

@ncfavier ncfavier requested a review from plt-amy June 5, 2024 14:20
@favonia favonia changed the title feat: 1-category Monad(C) def: 1-category Monad(C) Jun 5, 2024
@plt-amy plt-amy enabled auto-merge (squash) June 6, 2024 03:58
@plt-amy plt-amy merged commit a14aaa7 into the1lab:main Jun 6, 2024
3 checks passed
@favonia favonia deleted the monads branch June 6, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants