-
Notifications
You must be signed in to change notification settings - Fork 133
Implement Connection State Cycle #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MathewHDYT
wants to merge
24
commits into
thingsboard:master
Choose a base branch
from
MathewHDYT:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. Add new connection state example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the underlying
IMQTT _Client
Interface, with the option to either subscribe a callback that is informed whenever the underyling connection changes state (Connected, Connecting, Disconnected, Disconencting) or to directly read the current state. Additionally the exact error reason for the failure to connect is also received in the callback and can be read from the client as well.This allows to better manage the current state of the client, because the
Espressif_MQTT_Client
, does not connect in a blocking way likeArduino_MQTT_Client
, but instead sends a connect request and then returns immediately and will be informed again once the connection was successfull.For thesse new features a new example
0020-espressif_esp32_connection_state
has been created as well.Furthermore multiple issues have been fixed including fixed of other Pull Requests. Closes #254, closes #242.
Additionally I've also updated the GitHub Workflow Actions to update deprecated packages, so that they run again.
Array class has been adjusted to fix compilation issue, because setting the template parameter to 0 was possible. Closes #239.
Arduino_HTTP_Client has issues in combination with ESP-IDF Arduino, because of changes in Interface. Should have been reverted. Closes #240.
Adjust code to append additional null termination to Attribute Request char array. Closes #245.
Fix provisioning and ota unsubscribe call causing disconnect with cloud and connect cloud not even doing anything at all. Closes #247. Closes #248.
Additionally fixed an edge case where the connected state was set to true in the
Arduino_MQTT_Client
, even tough the connect method timed out or failed, because of invalid credentials. Closes #258, closes #256.Fix typo and adjust examples. Closes #238, closes #250, closes #241, closes #243, closes #246.
Includes chagnes from other PRs closes #260.
@imbeacon Would be nice if this could be merged and released as
v0.15.0
on PlatformIO, Arduino and Espressif Registry, as it includes a lot of vital bug fixes for provisioning as well as sending telemetry.