Allow hiding model attributes in redirects #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context ------- Spring Web MVC allows performing redirections by returning a String prefixed by `redirect://` in the controller. This String is intercepted by `ThymeleafViewResolver` which maps it to an instance of `RedirectView`. Problem ------- The default behaviour of `RedirectView` is to include all model attributes as query parameters. This behaviour may not be desirable and thymeleaf-spring does not provide a way to easily change it. Suggested fix ------------- Expose a method called `setRedirectExposeModelAttributes` in `ThymeleafViewResolver` to allow overriding this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Spring Web MVC allows performing redirections by returning a String prefixed by
redirect://in the controller.This String is intercepted by
ThymeleafViewResolverwhich maps it to an instance ofRedirectView.Problem
The default behaviour of
RedirectViewis to include all model attributes as query parameters.This behaviour may not be desirable and thymeleaf-spring does not provide a way to easily change it.
Suggested fix
Expose a method called
setRedirectExposeModelAttributesinThymeleafViewResolverto allow overriding this behaviour.