fix: iOS optionDialog cancel option

[m1ga]

Alloy:

<Alloy>
    <Window>
        <!-- some other modules, actionbar, views and a listview -->

        <OptionDialog id="dialog" title="Delete item?" onClick="onClickDialog">
            <Options>
                <Option>Yes</Option>
                <Option cancel="true">No</Option>
            </Options>
        </OptionDialog>
    </Window>
</Alloy>

generated

var __alloyId22 = [];
__alloyId22.push("Yes");
__alloyId19 = __alloyId22.push("No") - 1;                    // <- error
$.__views["dialog"] = Ti.UI.createOptionDialog({
  options: __alloyId22,
  cancel: __alloyId19,
  id: "dialog",
  title: "Delete item?"
});

with

[ERROR] TiExceptionHandler:
[ERROR] TiExceptionHandler: ReferenceError: __alloyId19 is not defined
[ERROR] TiExceptionHandler:     at new Controller (/alloy/controllers/machine.js:325:6199)
[ERROR] TiExceptionHandler:     at Object.exports.createController (/alloy.js:427:8)
[ERROR] TiExceptionHandler:     at Button.onClickGo (/alloy/controllers/index.js:251:21)
[ERROR] TiExceptionHandler:     at Button.value (ti:/kroll.js:1430:27)
[ERROR] TiExceptionHandler:     at Button.value (ti:/kroll.js:1477:25)

The <OptionDialog> works fine in a blank project 🤷

This PR will add a var infront of __alloyId19:

var __alloyId22 = [];
__alloyId22.push("Yes");
var __alloyId19 = __alloyId22.push("No") - 1;                    // <- fix
$.__views["dialog"] = Ti.UI.createOptionDialog({
  options: __alloyId22,
  cancel: __alloyId19,
  id: "dialog",
  title: "Delete item?"
});

and the projects builds fine

[hansemannn]

I am not confident to review this properly, as it's a change directly in the core compiler. Maybe @cb1kenobi or @janvennemann can help here?

[janvennemann]

Small suggestion to update the else block as well. Then it should be good to go.