Skip to content

[GLE-10323] fix(algo): fix tg_maxflow algorithm; #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

DavidFan2000
Copy link
Contributor

@DavidFan2000 DavidFan2000 commented Jun 6, 2025

PR Summary

  • GLE-10323
    • Old MaxFlow implementation was incorrect, and it didn't even work with the example we provided on our documentation. I checked with support engineers on this topic, and it seems like we never actually finished implementing MaxFlow algorithm in the first place
    • This is a new implementation of MaxFlow algorithm. Test done in QA-8174

PR Checklist

  • Added comments for more comprehensible code.
  • Added unit and/or regression tests.
    • Yiping added test cases to BigTest in QA-8208
  • (Optional) Notified Doc/Prod team, if this PR contains any new features.

What is the behavior change?

Other information:

Related PRs:

@DavidFan2000 DavidFan2000 marked this pull request as draft June 6, 2025 22:44
@DavidFan2000 DavidFan2000 marked this pull request as ready for review June 9, 2025 22:35
@DavidFan2000 DavidFan2000 requested review from dadongwang-tg, robertBuechner and chengbiao-jin and removed request for robertBuechner June 9, 2025 22:35
@DavidFan2000 DavidFan2000 changed the title GLE-10323 fix(algo): fix tg_maxflow algorithm [GLE-10323] fix(algo): fix tg_maxflow algorithm; Jun 9, 2025
Copy link
Collaborator

@qe-tigergraph qe-tigergraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:cowboy:  [sv4] MIT#31145 on tg_4.3.0_dev(gsql-graph-algorithms#179) SUCCEED
Jenkins Job: Check jenkins job
Result: MIT Job succeed!!
timecost: 1 hours, 58 minutes, 32.883 seconds
Instance Type: cluster
Tested OS: centos7,ubuntu20,ubuntu18,centos8
AuotPort: https://jenkins.graphtiger.com/job/autoport_pipeline/2479/console
Requestor: david.fan

Copy link
Collaborator

@qe-tigergraph qe-tigergraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:beach:  [sv4] build_job#66738 of WIP#66149 on tg_4.3.0_dev(gsql-graph-algorithms#179) at 2025/06/09 17:00:51 (PST) BUILT
Reason: Build successful
Jenkins Job: Check jenkins job
Requestor: david.fan
masterUrl: https://jenkins.graphtiger.com/job/wip_test/66149
Comment: Your binary is ready in download site, please click here or use curl/wget to download it, also on nfs

Copy link
Collaborator

@qe-tigergraph qe-tigergraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:beach:  [sv4] build_job#66858 of MIT#31145 on tg_4.3.0_dev(gsql-graph-algorithms#179) at 2025/06/11 15:54:10 (PST) BUILT
Reason: Build successful
Jenkins Job: Check jenkins job
Requestor: david.fan
masterUrl: https://jenkins.graphtiger.com/job/mit_test/31145
Comment: Your binary is ready in download site, please click here or use curl/wget to download it, also on nfs

Copy link
Collaborator

@qe-tigergraph qe-tigergraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎  [sv4] MIT#31145 on tg_4.3.0_dev(gsql-graph-algorithms#179) PASS
Jenkins Job: Check jenkins job
Result: MIT Test passed! Waiting for merging
Requestor: david.fan

@qe-tigergraph qe-tigergraph merged commit c8ca472 into tg_4.3.0_dev Jun 11, 2025
0 of 4 checks passed
@qe-tigergraph qe-tigergraph deleted the GLE-10323 branch June 11, 2025 23:17
qe-tigergraph added a commit that referenced this pull request Jun 12, 2025
qe-tigergraph added a commit that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants