Skip to content

add parseArg to Argument class #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

add parseArg to Argument class #2359

merged 2 commits into from
Apr 28, 2025

Conversation

mateussilva92
Copy link
Contributor

Problem

Missing parseArg property on Arguments class

Solution

Adding the missing property to the class

ChangeLog

Add parseArg to property to Arguments class
Rename fn parameter in argument method to parseArg to be inline with the option method

@mateussilva92 mateussilva92 mentioned this pull request Apr 27, 2025
Merged
@mateussilva92 mateussilva92 changed the base branch from master to develop April 27, 2025 10:39
shadowspawn
shadowspawn approved these changes Apr 27, 2025
View reviewed changes
Copy link
Collaborator

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadowspawn
Copy link
Collaborator

Thanks @mateussilva92

@shadowspawn shadowspawn merged commit 0371e80 into tj:develop Apr 28, 2025
11 checks passed
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Apr 28, 2025
@mateussilva92 mateussilva92 deleted the arg-parseArg branch April 28, 2025 08:02
@shadowspawn
Copy link
Collaborator

This has been released in Commander v14.

@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateussilva92 @shadowspawn @abetomo