flake: increase flake max line length

[Managor]

No description provided.

[kbdharun]

LGTM.

The original value was set a bit higher with respect to PEP8 which suggested a max of 80 lines to view code in terminals with ease. But nowadays it's fine to have 120 or higher so let's proceed with the changes.

[Managor]

Yeah traditional terminals are not being used anywhere so the original limit makes no sense.

[kbdharun]

I think black defaults to 89 line length will check online and get back to see if we need to update/define a custom value in a config file.

[sebastiaanspeck]

This is the flake8 configuration in tldr itself: https://github.com/tldr-pages/tldr/blob/main/.flake8

[kbdharun]

Was going through related discussions online about max line length, some places suggest a maximum of 120 (since it's used by default in IDE's like PyCharm to match with IntelliJ) and any nested single line won't be too long.

Or else, as majority suggests online (and to be uniform with main repo), let's keep the current value of 88 as it is to not modify black's config, but instead use line breaks and backslashes to divide contents over multiple lines. And to prevent sending PR before addressing this, maybe we can add a precommit hook.

[Managor]

But forced multiline looks ugly as hell. See the warning message in the other PR. There's no reason for it to be split into 3-4 lines

[kbdharun]

But forced multiline looks ugly as hell. See the warning message in the other PR. There's no reason for it to be split into 3-4 lines

Agreed, the current tldr.py file is so long since we are using line breaks due to the 88 restriction, 150 should be fine for normal use in an IDE, but 100/120 would be fine if you want to open 2 files side by side.

For instance, this is with the current 88 configuration in my laptop in full screen, there is still a small side scroll in some places (so if it's 150, it will be too large):

If we agree on setting it as 100/120 here, let's update tldr's flake8 config to the same for consistency across places.

[Managor]

120 is better than 88. I don't care as long as the minimum length is made longer. My main goal is to just get the warning message and autocomplete fixed and pushed into a new version.