Skip to content

requirements: install colorama on all platforms #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

requirements: install colorama on all platforms #298

merged 2 commits into from
Aug 15, 2025

Conversation

Managor
Copy link
Member

@Managor Managor commented Aug 15, 2025

I assume this change installs colorama on all platforms to get rid of a CI error.

@sebastiaanspeck
Copy link
Member

Looking at colorama itself; it hasn’t had a release since 2022 and the maintenance is very low. Do we still want this requirement? @kbdharun

@Managor Managor dismissed sebastiaanspeck’s stale review August 15, 2025 05:25

Request fulfilled

@Managor
Copy link
Member Author

Managor commented Aug 15, 2025

I want to get the other PR fixed and done. We can change the library later in a later PR

@Managor Managor merged commit 78511f1 into main Aug 15, 2025
63 checks passed
@Managor Managor deleted the colorama branch August 15, 2025 05:26
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at colorama itself; it hasn’t had a release since 2022 and the maintenance is very low. Do we still want this requirement? @kbdharun

Just checked the Colorama repo, it's still being actively maintained and works for recent Python versions (and is supported by Tidelift, who sponsors these FOSS projects in exchange for professional support) since it's a generic library and there isn't any major changes there doesn't seem to be new releases since 2022, but it should work as intended for the near future.

I don't think we would need to look for an immediate alternative now, but if stops functioning or has security/dependency issues we can replace it in the future, for now the current PRs changes LGTM (Pyproject file needs to be updates too, will do it in main PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants