Add unit tests for execution package to achieve 100% coverage #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test thread naming with prefix and incrementing numbers - Test multiple threads creation - Test thread properties (non-daemon) - Test different prefixes and special characters - Test thread execution of runnables
- Test construction with empty and non-empty lists - Test that getter methods return copies (defensive copying) - Test immutability of internal lists - Test preservation of list order
- Test abstract methods implementation - Test execute method behavior - Test shutdown method behavior - Test InterruptedException handling - Verify abstract class and method signatures
- Test both constructors (with and without probe lists) - Test scan flow with prerequisites check - Test probe registration methods - Test lifecycle methods (onScanStart, onScanEnd) - Test integration with SiteReportRater and Guidelines - Test file output functionality - Test timing measurements - Test AutoCloseable implementation
- Test basic construction and configuration - Test all submit methods (Runnable, Runnable with result, Callable) - Test semaphore release behavior on success and failure - Test task timeout functionality - Test multiple concurrent tasks - Test shutdown behavior and policies - Test edge cases like tasks completing before timeout
- Test basic execution flow with probes and after probes - Test handling of probes that cannot be executed - Test exception handling during probe execution - Test property change listener functionality - Test statistics collection and merging - Test shutdown and AutoCloseable interface - Test custom executor constructor - Test edge cases (empty probe list, invalid property changes) - Test merging of extracted value containers
- Update test probe implementations to match ScannerProbe API - Add required method implementations (mergeData, getRequirements) - Fix constructor calls to use ProbeType parameter - Add missing imports and methods in TestReport
- Add serializeToJson implementation to all TestReport classes - Replace lambda requirements with concrete Requirement implementations - Fix TestScanner to implement close() method - Update SiteReportRater constructor call with proper parameters - Fix ExecutorConfig method calls (use setOutputFile with String) - Update all references from getExecutedProbes() to getExecutedProbeTypes()
- Fix Guideline constructor to use 3 parameters - Change List to Set for probe type collections in TestReport - Add missing imports (HashSet, Set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
de.rub.nds.scanner.core.executionpackageChanges
NamedThreadFactoryTest: Tests thread naming, incrementing numbers, and thread propertiesScanJobTest: Tests construction, list copying, and immutabilityScanJobExecutorTest: Tests abstract class implementation and method signaturesScannerTest: Tests scan flow, prerequisites, probe registration, file output, and lifecycleScannerThreadPoolExecutorTest: Tests thread pool behavior, timeouts, and semaphore handlingThreadedScanJobExecutorTest: Tests concurrent execution, property changes, and statistics collection