-
Notifications
You must be signed in to change notification settings - Fork 16
Introduce unit_vector_norm. #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sethaxen, this is based on your work, but I added a lot of notes and a generic API because I believe that similar transformations will be added in the future. If your time allows it would be great if you could review since you actually understand the math and my don't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor comments/suggestions.
Co-authored-by: Seth Axen <[email protected]>
Co-authored-by: Seth Axen <[email protected]>
…' into tp/sethaxen-unitvector-normalize
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: @sethaxen
UnitVector
(better to change the name for a new transformation), closing Request for documentation of the UnitVector transformation #86