Skip to content

Introduce unit_vector_norm. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 6, 2025
Merged

Introduce unit_vector_norm. #139

merged 15 commits into from
May 6, 2025

Conversation

tpapp
Copy link
Owner

@tpapp tpapp commented May 2, 2025

Co-authored-by: @sethaxen

Co-authored-by: @sethaxen

- add unit_vector_transform using a projection to the unit sphere.
  fixes #66
- deprecates `UnitVector` (better to change the name for a new
  transformation), closing #86
- add a generic interface for log prior corrections (public, but not exported)
@tpapp tpapp requested a review from devmotion May 2, 2025 13:42
@tpapp
Copy link
Owner Author

tpapp commented May 2, 2025

@sethaxen, this is based on your work, but I added a lot of notes and a generic API because I believe that similar transformations will be added in the future. If your time allows it would be great if you could review since you actually understand the math and my don't.

Copy link
Contributor

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments/suggestions.

@tpapp tpapp merged commit fc6be1d into master May 6, 2025
5 of 6 checks passed
@tpapp tpapp deleted the tp/sethaxen-unitvector-normalize branch May 6, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnitVector only transforms to positive hemisphere
3 participants