Use bundled fonts in the documentation #26247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will solve the same issue in #26031 but for the trino docs |
wendigo
reviewed
Jul 22, 2025
wendigo
reviewed
Jul 22, 2025
|
Please rephrase the commit title https://trino.io/development/process.html#pull-request-and-commit-guidelines- |
wendigo
force-pushed
the
add-local-fonts-to-docs
branch
from
4aec5a7 to
1c71ce4
Compare
wendigo
changed the title
wendigo
force-pushed
the
add-local-fonts-to-docs
branch
from
1c71ce4 to
84634c1
Compare
|
Seems like the docs are also trying to access github.com which can also be hurtful in a private domain, I will implement a way to check it before trying to acces it, @wendigo would you like it to be in a new pull request or should i add the changes here? |
|
@nadavtzaysler no. There is no point in doing that |
wendigo
force-pushed
the
add-local-fonts-to-docs
branch
from
d00335f to
fcbcc15
Compare
|
I've dropped last commit. Please create separate change for it. |
wendigo
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(X ) This is not user-visible or is docs only, and no release notes are required.