Add user and password config to MySQL event listener #26260

danielbelchior · 2025-07-22T09:53:03Z

Description

This PR introduces support for configuring MySQL credentials in the event listener using the new properties mysql-event-listener.db.user and mysql-event-listener.db.password.
These properties allow users to specify the database username and password separately from the JDBC URL, making configuration more secure and user-friendly, especially when passwords contain special characters. The connection logic now uses these properties if provided, falling back to credentials in the JDBC URL if not set.
Documentation has been updated to reflect the new configuration options.

Additional context and related issues

This change aligns the MySQL event listener configuration with the approach used by other Trino connectors, improving consistency and usability. It addresses issues encountered when embedding credentials with special characters in the JDBC URL and enhances security by allowing sensitive information to be managed separately. No related issues were referenced, but this update is based on common best practices and user feedback.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text:

## MySQL event Listener
* Supports separate configuration properties for database username and password ({issue}`25941`)

Closes: #25941

cla-bot · 2025-07-22T09:53:06Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-22T09:56:45Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java

docs/src/main/sphinx/admin/event-listeners-mysql.md

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java

cla-bot · 2025-07-23T09:20:22Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T09:21:05Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T09:26:55Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr

Remove Feat(mysql-event-listener): from the commit title, and wrap the commit body at 72 characters. See https://trino.io/development/process.html#pull-request-and-commit-guidelines- for more details.

cla-bot · 2025-07-23T09:44:44Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-23T10:32:42Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Allow configuring MySQL credentials for the event listener using separate mysql-event-listener.db.user and mysql-event-listener.db.password properties. This makes it easier and safer to provide credentials, especially when passwords contain special characters, and aligns with the configuration style of other Trino connectors. The connection logic now uses these properties if provided, falling back to credentials in the JDBC URL if not set.

cla-bot · 2025-07-23T10:57:21Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr · 2025-07-24T03:23:46Z

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java

+            if (getUser().isPresent() && url != null && url.matches(".*[?&]user=.+")) {
+                throw new RuntimeException("'user' property is set, but JDBC URL also contains 'user' in the query string. Please specify the user only once.");
+            }
+            // Check for password property
+            if (getPassword().isPresent() && url != null && url.matches(".*[?&]password=.+")) {
+                throw new RuntimeException("'password' property is set, but JDBC URL also contains 'password' in the query string. Please specify the password only once.");
+            }


I don't think we want to parse the URL by ourselves. Please consider using helper methods in MySQL JDBC driver, e.g. ConnectionUrlParser.parseConnectionString method

ebyhr · 2025-07-27T22:23:31Z

@cla-bot check

cla-bot · 2025-07-27T22:23:34Z

The cla-bot has been summoned, and re-checked this pull request!

github-actions bot added the docs label Jul 22, 2025

danielbelchior changed the title ~~Feat(mysql-event-listener): Add user and password config to MySQL event listener~~ Add user and password config to MySQL event listener Jul 22, 2025

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from ad6a7cb to 7eb43bb Compare July 22, 2025 09:56

ebyhr reviewed Jul 22, 2025

View reviewed changes

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java Outdated Show resolved Hide resolved

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java Outdated Show resolved Hide resolved

ebyhr reviewed Jul 22, 2025

View reviewed changes

docs/src/main/sphinx/admin/event-listeners-mysql.md Outdated Show resolved Hide resolved

ebyhr reviewed Jul 22, 2025

View reviewed changes

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java Show resolved Hide resolved

...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java Show resolved Hide resolved

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from 7eb43bb to 1d09790 Compare July 23, 2025 09:20

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from 1d09790 to e98d7cf Compare July 23, 2025 09:21

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from e98d7cf to 8968d7a Compare July 23, 2025 09:26

ebyhr reviewed Jul 23, 2025

View reviewed changes

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from 8968d7a to 41124be Compare July 23, 2025 09:44

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from 41124be to a3a6c3f Compare July 23, 2025 10:32

danielbelchior force-pushed the mysql-event-listener-add-credentials-config branch from a3a6c3f to 8dff8ac Compare July 23, 2025 10:57

ebyhr reviewed Jul 24, 2025

View reviewed changes

cla-bot bot added the cla-signed label Jul 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add user and password config to MySQL event listener #26260

Add user and password config to MySQL event listener #26260

Uh oh!

danielbelchior commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

ebyhr left a comment

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

ebyhr Jul 24, 2025

Uh oh!

ebyhr commented Jul 27, 2025

Uh oh!

cla-bot bot commented Jul 27, 2025

Uh oh!

Uh oh!

Add user and password config to MySQL event listener #26260

Are you sure you want to change the base?

Add user and password config to MySQL event listener #26260

Uh oh!

Conversation

danielbelchior commented Jul 22, 2025

Description

Additional context and related issues

Release notes

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

cla-bot bot commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

ebyhr left a comment

Choose a reason for hiding this comment

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

cla-bot bot commented Jul 23, 2025

Uh oh!

ebyhr Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

ebyhr commented Jul 27, 2025

Uh oh!

cla-bot bot commented Jul 27, 2025

Uh oh!

Uh oh!