Minor cleanup in RefreshView tests #26282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn’t know that syntax until now :) |
|
Thanks to @ebyhr for implementing it |
ebyhr
approved these changes
Jul 28, 2025
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
Each connector might have a different way of handling drops and column rename, we use EXCEPT CORRESPONDING clause to ensure the results of the both the views and tables are same. Additionally fixed error message when dropping a column.
Praveen2112
force-pushed
the
praveen/view_test_cleanups
branch
from
b2af241 to
bc6bfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each connector might have a different way of handling drops and column rename, we use EXCEPT CORRESPONDING clause to ensure the results of the both the views and tables are same. Additionally fixed error message when dropping a column.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.